all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* accept more version names in file-name-sans-versions
@ 2007-09-20  1:14 Dan Nicolaescu
  2007-09-20  8:52 ` Juri Linkov
  0 siblings, 1 reply; 15+ messages in thread
From: Dan Nicolaescu @ 2007-09-20  1:14 UTC (permalink / raw)
  To: emacs-devel


For a file file.c managed by git doing
C-u C-x v = master RET

will create the buffer file.c.~master~ with the major-mode
fundamental-mode not c-mode.

The reason is that file-name-sans-versions only looks for revision
names matching ".~[0-9.]+~", so .~master~ does not match. 

Any reason not to add a-z to that regexp?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-20  1:14 accept more version names in file-name-sans-versions Dan Nicolaescu
@ 2007-09-20  8:52 ` Juri Linkov
  2007-09-22  2:14   ` Dan Nicolaescu
  0 siblings, 1 reply; 15+ messages in thread
From: Juri Linkov @ 2007-09-20  8:52 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel

> For a file file.c managed by git doing
> C-u C-x v = master RET
>
> will create the buffer file.c.~master~ with the major-mode
> fundamental-mode not c-mode.
>
> The reason is that file-name-sans-versions only looks for revision
> names matching ".~[0-9.]+~", so .~master~ does not match.
>
> Any reason not to add a-z to that regexp?

Then please add also "-" since often the revision name contains it,
e.g. file.c.~multi-tty~ or file.c.~2007-09-20~

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-20  8:52 ` Juri Linkov
@ 2007-09-22  2:14   ` Dan Nicolaescu
  2007-09-22  8:52     ` Andreas Schwab
  0 siblings, 1 reply; 15+ messages in thread
From: Dan Nicolaescu @ 2007-09-22  2:14 UTC (permalink / raw)
  To: Juri Linkov; +Cc: emacs-devel

Juri Linkov <juri@jurta.org> writes:

  > > For a file file.c managed by git doing
  > > C-u C-x v = master RET
  > >
  > > will create the buffer file.c.~master~ with the major-mode
  > > fundamental-mode not c-mode.
  > >
  > > The reason is that file-name-sans-versions only looks for revision
  > > names matching ".~[0-9.]+~", so .~master~ does not match.
  > >
  > > Any reason not to add a-z to that regexp?
  > 
  > Then please add also "-" since often the revision name contains it,
  > e.g. file.c.~multi-tty~ or file.c.~2007-09-20~

Good idea, I made the changes on the EMACS_22_BASE branch.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22  2:14   ` Dan Nicolaescu
@ 2007-09-22  8:52     ` Andreas Schwab
  2007-09-22 15:48       ` Richard Stallman
  0 siblings, 1 reply; 15+ messages in thread
From: Andreas Schwab @ 2007-09-22  8:52 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: Juri Linkov, emacs-devel

Dan Nicolaescu <dann@ics.uci.edu> writes:

> Juri Linkov <juri@jurta.org> writes:
>
>   > > For a file file.c managed by git doing
>   > > C-u C-x v = master RET
>   > >
>   > > will create the buffer file.c.~master~ with the major-mode
>   > > fundamental-mode not c-mode.
>   > >
>   > > The reason is that file-name-sans-versions only looks for revision
>   > > names matching ".~[0-9.]+~", so .~master~ does not match.
>   > >
>   > > Any reason not to add a-z to that regexp?
>   > 
>   > Then please add also "-" since often the revision name contains it,
>   > e.g. file.c.~multi-tty~ or file.c.~2007-09-20~
>
> Good idea, I made the changes on the EMACS_22_BASE branch.

Now if you are checking out revision EMACS_22_BASE it still does not
work. :-)

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22  8:52     ` Andreas Schwab
@ 2007-09-22 15:48       ` Richard Stallman
  2007-09-22 16:00         ` Andreas Schwab
  2007-09-22 16:20         ` Dan Nicolaescu
  0 siblings, 2 replies; 15+ messages in thread
From: Richard Stallman @ 2007-09-22 15:48 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: juri, dann, emacs-devel

    Now if you are checking out revision EMACS_22_BASE it still does not
    work. :-)

Could you please send me a *precise* test case for this bug?  The test
case should start with `emacs -q', so that your .emacs file does not
affect it, and it should show exactly what text to put in the buffer,
what commands to execute, and how and where to click.  Also please say
exactly what incorrect results you get.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 15:48       ` Richard Stallman
@ 2007-09-22 16:00         ` Andreas Schwab
  2007-09-23 15:05           ` Richard Stallman
  2007-09-22 16:20         ` Dan Nicolaescu
  1 sibling, 1 reply; 15+ messages in thread
From: Andreas Schwab @ 2007-09-22 16:00 UTC (permalink / raw)
  To: rms; +Cc: juri, dann, emacs-devel

Richard Stallman <rms@gnu.org> writes:

>     Now if you are checking out revision EMACS_22_BASE it still does not
>     work. :-)
>
> Could you please send me a *precise* test case for this bug?

Please look again.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 15:48       ` Richard Stallman
  2007-09-22 16:00         ` Andreas Schwab
@ 2007-09-22 16:20         ` Dan Nicolaescu
  2007-09-22 16:31           ` Michaël Cadilhac
  1 sibling, 1 reply; 15+ messages in thread
From: Dan Nicolaescu @ 2007-09-22 16:20 UTC (permalink / raw)
  To: rms; +Cc: juri, Andreas Schwab, emacs-devel

Richard Stallman <rms@gnu.org> writes:

  >     Now if you are checking out revision EMACS_22_BASE it still does not
  >     work. :-)
  > 
  > Could you please send me a *precise* test case for this bug?  The test
  > case should start with `emacs -q', so that your .emacs file does not
  > affect it, and it should show exactly what text to put in the buffer,
  > what commands to execute, and how and where to click.  Also please say
  > exactly what incorrect results you get.

The problem is fixed now on the EMACS_22_BASE branch, it will
propagate to the trunk whenever Miles restarts his merging.

There was a precise description in the original message, it was using
git.  Here's one using CVS:

emacs -q 
C-x C-f emacs/lisp/subr.el RET
C-u C-x v ~ EMACS_22_BASE RET

Before the fix the resulting buffer subr.el.~EMACS_22_BASE~ was not
put in emacs-lisp-mode, but in fundamental-mode.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 16:20         ` Dan Nicolaescu
@ 2007-09-22 16:31           ` Michaël Cadilhac
  2007-09-22 17:52             ` Dan Nicolaescu
                               ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Michaël Cadilhac @ 2007-09-22 16:31 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: emacs-devel


[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> The problem is fixed now on the EMACS_22_BASE branch, it will
> propagate to the trunk whenever Miles restarts his merging.
>
> There was a precise description in the original message, it was using
> git.  Here's one using CVS:
>
> emacs -q 
> C-x C-f emacs/lisp/subr.el RET
> C-u C-x v ~ EMACS_22_BASE RET

BTW, the regexp is :
		     (or (string-match "\\.~[-0-9a-z._]+~\\'" name)

If the user has case-fold-search set to nil, it's risky to not put A-Z
here, nop?

-- 
 |   Michaël `Micha' Cadilhac       |  To be portable,                       |
 |   http://michael.cadilhac.name   |    Just stay on Windows.               |
 |   JID/MSN:                       |                                        |
 `----  michael.cadilhac@gmail.com  |          -- A Microsoft Guy       -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 16:31           ` Michaël Cadilhac
@ 2007-09-22 17:52             ` Dan Nicolaescu
  2007-09-22 20:02             ` Stefan Monnier
  2007-09-22 20:04             ` Stefan Monnier
  2 siblings, 0 replies; 15+ messages in thread
From: Dan Nicolaescu @ 2007-09-22 17:52 UTC (permalink / raw)
  To: Michaël Cadilhac; +Cc: emacs-devel

michael@cadilhac.name (Michaël Cadilhac) writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > > The problem is fixed now on the EMACS_22_BASE branch, it will
  > > propagate to the trunk whenever Miles restarts his merging.
  > >
  > > There was a precise description in the original message, it was using
  > > git.  Here's one using CVS:
  > >
  > > emacs -q 
  > > C-x C-f emacs/lisp/subr.el RET
  > > C-u C-x v ~ EMACS_22_BASE RET
  > 
  > BTW, the regexp is :
  > 		     (or (string-match "\\.~[-0-9a-z._]+~\\'" name)
  > 
  > If the user has case-fold-search set to nil, it's risky to not put A-Z
  > here, nop?

Thanks, added A-Z too.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 16:31           ` Michaël Cadilhac
  2007-09-22 17:52             ` Dan Nicolaescu
@ 2007-09-22 20:02             ` Stefan Monnier
  2007-09-22 20:04             ` Stefan Monnier
  2 siblings, 0 replies; 15+ messages in thread
From: Stefan Monnier @ 2007-09-22 20:02 UTC (permalink / raw)
  To: Michaël Cadilhac; +Cc: Dan Nicolaescu, emacs-devel

> BTW, the regexp is :
> 		     (or (string-match "\\.~[-0-9a-z._]+~\\'" name)

> If the user has case-fold-search set to nil, it's risky to not put A-Z
> here, nop?

Not quite: you want [:alnum:] in place of 0-9a-zA-Z.


        Stefan

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 16:31           ` Michaël Cadilhac
  2007-09-22 17:52             ` Dan Nicolaescu
  2007-09-22 20:02             ` Stefan Monnier
@ 2007-09-22 20:04             ` Stefan Monnier
  2007-09-23 16:14               ` Dan Nicolaescu
  2 siblings, 1 reply; 15+ messages in thread
From: Stefan Monnier @ 2007-09-22 20:04 UTC (permalink / raw)
  To: Michaël Cadilhac; +Cc: Dan Nicolaescu, emacs-devel

> 		     (or (string-match "\\.~[-0-9a-z._]+~\\'" name)

Oh, and: Arch uses @ and Monotone sometimes uses : and # as well.
I think we'd better think the other way around: which chars do we want
to disallow.


        Stefan

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 16:00         ` Andreas Schwab
@ 2007-09-23 15:05           ` Richard Stallman
  2007-09-23 16:11             ` Andreas Schwab
  0 siblings, 1 reply; 15+ messages in thread
From: Richard Stallman @ 2007-09-23 15:05 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: juri, dann, emacs-devel

    >     Now if you are checking out revision EMACS_22_BASE it still does not
    >     work. :-)
    >
    > Could you please send me a *precise* test case for this bug?

    Please look again.

All I see is the sentence quoted above.  It says that something still
does not work, but I am not sure WHAT does not work.  Is it the
original bug?  Something else?

(Has this been dealt with?)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-23 15:05           ` Richard Stallman
@ 2007-09-23 16:11             ` Andreas Schwab
  2007-09-24 18:20               ` Richard Stallman
  0 siblings, 1 reply; 15+ messages in thread
From: Andreas Schwab @ 2007-09-23 16:11 UTC (permalink / raw)
  To: rms; +Cc: juri, dann, emacs-devel

Richard Stallman <rms@gnu.org> writes:

>     >     Now if you are checking out revision EMACS_22_BASE it still does not
>     >     work. :-)
>     >
>     > Could you please send me a *precise* test case for this bug?
>
>     Please look again.
>
> All I see is the sentence quoted above.

Did you see the smiley?

> (Has this been dealt with?)

Of course.  Even before I sent the mail.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-22 20:04             ` Stefan Monnier
@ 2007-09-23 16:14               ` Dan Nicolaescu
  0 siblings, 0 replies; 15+ messages in thread
From: Dan Nicolaescu @ 2007-09-23 16:14 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Michaël Cadilhac, emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

  > > 		     (or (string-match "\\.~[-0-9a-z._]+~\\'" name)
  > 
  > Oh, and: Arch uses @ and Monotone sometimes uses : and # as well.

Git can also use ^. I added all these and used :alnum:

  > I think we'd better think the other way around: which chars do we want
  > to disallow.

We can make that change once a decision what to use is made...

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: accept more version names in file-name-sans-versions
  2007-09-23 16:11             ` Andreas Schwab
@ 2007-09-24 18:20               ` Richard Stallman
  0 siblings, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2007-09-24 18:20 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: juri, dann, emacs-devel

    Did you see the smiley?

Yes, but I do not understand what it means:

>     >     Now if you are checking out revision EMACS_22_BASE it still does not
>     >     work. :-)

It is so clever and cryptic that I could not understand it.

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2007-09-24 18:20 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-20  1:14 accept more version names in file-name-sans-versions Dan Nicolaescu
2007-09-20  8:52 ` Juri Linkov
2007-09-22  2:14   ` Dan Nicolaescu
2007-09-22  8:52     ` Andreas Schwab
2007-09-22 15:48       ` Richard Stallman
2007-09-22 16:00         ` Andreas Schwab
2007-09-23 15:05           ` Richard Stallman
2007-09-23 16:11             ` Andreas Schwab
2007-09-24 18:20               ` Richard Stallman
2007-09-22 16:20         ` Dan Nicolaescu
2007-09-22 16:31           ` Michaël Cadilhac
2007-09-22 17:52             ` Dan Nicolaescu
2007-09-22 20:02             ` Stefan Monnier
2007-09-22 20:04             ` Stefan Monnier
2007-09-23 16:14               ` Dan Nicolaescu

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.