From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ralf Angeli Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Image in before-string of overlay interferes with keymap Date: Thu, 28 Feb 2008 20:03:59 +0100 Message-ID: <87zltklx7k.fsf@photon.caeruleus.net> References: <87fxw593iu.fsf@photon.caeruleus.net> <877igsewqi.fsf@photon.caeruleus.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204225522 10129 80.91.229.12 (28 Feb 2008 19:05:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 19:05:22 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 20:05:28 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUo3s-0008PG-En for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 20:04:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUo3M-00041R-AN for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 14:04:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUo3I-0003zd-Dn for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:04:20 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUo3G-0003yz-Lk for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:04:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUo3G-0003ys-F5 for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:04:18 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUo3G-0000DN-7B for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:04:18 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JUo3F-0002Jb-QX for emacs-pretest-bug@gnu.org; Thu, 28 Feb 2008 14:04:17 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JUo3C-0000C3-82 for emacs-pretest-bug@gnu.org; Thu, 28 Feb 2008 14:04:17 -0500 Original-Received: from moutng.kundenserver.de ([212.227.126.177]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUo3B-00008X-Oq; Thu, 28 Feb 2008 14:04:14 -0500 Original-Received: from photon.caeruleus.net (p54A52F77.dip0.t-ipconnect.de [84.165.47.119]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1JUo2x3Y0d-0004f5; Thu, 28 Feb 2008 20:04:00 +0100 In-Reply-To: <877igsewqi.fsf@photon.caeruleus.net> (Ralf Angeli's message of "Mon, 25 Feb 2008 19:07:01 +0100") X-Provags-ID: V01U2FsdGVkX19BDcqxKWMEXWCHx7IhdChwyMI5kDUgSEoPkHL zboW2zWkVCibhxDxB9cwc0/9v/WZFanPRFXKTL2nm1q9hD5RDN A5rq+ISt75Y5i0Ghv/YpQ== X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90759 gmane.emacs.pretest.bugs:21337 Archived-At: * Ralf Angeli (2008-02-25) writes: > * Richard Stallman (2008-02-10) writes: > >> Would someone please fix this and ack? >> >> From: Ralf Angeli >> To: emacs-pretest-bug@gnu.org >> Date: Wed, 06 Feb 2008 22:30:17 +0100 >> Subject: 23.0.60; Image in before-string of overlay interferes with keymap >> >> As soon as an image is used in the before-string property of an overlay, >> mouse clicks as defined in a keymap for the propertized string are not >> recognized anymore. > > As additional info, AFAICS the following change introduced the bug: > > 2007-10-16 YAMAMOTO Mitsuharu > > * xdisp.c (handle_display_prop): Ignore display specs after > replacing one when string text is being replaced. > (handle_single_display_spec): Pretend as if characters with display > property haven't been consumed only when buffer text is being replaced. Some more information ... The original report and discussion which lead to the change can be found here: The ironic part here is that while the reports Joe sent were concerned with helping to fix Emacs to better support preview-latex and folding of TeX macros, the resulting change actually broke preview-latex. I could narrow down the problematic part of the change. If the following part of the patch (diff between revision 1.1170 and 1.1171 of xdisp.c) is reverted, the test case I sent in my original report will work again. @@ -4245,7 +4260,8 @@ /* Say that we haven't consumed the characters with `display' property yet. The call to pop_it in set_iterator_to_next will clean this up. */ - *position = start_pos; + if (BUFFERP (object)) + it->current.pos = start_pos; } #endif /* HAVE_WINDOW_SYSTEM */ The test case Joe sent in his report will work as well, but this is likely only due to the fact that the part shown above is not related to strings (where an analogous change was made.) Could somebody please help me fix this before Emacs 22.2 is released? I'd hate to see preview-latex broken until the successor of 22.2 will be released. -- Ralf