From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sven Joachim Newsgroups: gmane.emacs.devel Subject: Re: unable to copy directory recursively to a vfat partition Date: Thu, 24 Jul 2008 07:30:21 +0200 Message-ID: <87zlo7zw5u.fsf@gmx.de> References: <20080723185150.txs6e4gbr23ow0g4@webmail.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1216877767 23843 80.91.229.12 (24 Jul 2008 05:36:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jul 2008 05:36:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 24 07:36:56 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KLtVU-0004SX-06 for ged-emacs-devel@m.gmane.org; Thu, 24 Jul 2008 07:36:52 +0200 Original-Received: from localhost ([127.0.0.1]:51531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLtUa-000212-FO for ged-emacs-devel@m.gmane.org; Thu, 24 Jul 2008 01:35:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLtUQ-0001xp-Or for emacs-devel@gnu.org; Thu, 24 Jul 2008 01:35:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLtUO-0001vH-4X for emacs-devel@gnu.org; Thu, 24 Jul 2008 01:35:45 -0400 Original-Received: from [199.232.76.173] (port=42128 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLtUN-0001v3-OI for emacs-devel@gnu.org; Thu, 24 Jul 2008 01:35:43 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:34922) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KLtUN-0002xB-Oa for emacs-devel@gnu.org; Thu, 24 Jul 2008 01:35:44 -0400 Original-Received: (qmail invoked by alias); 24 Jul 2008 05:35:40 -0000 Original-Received: from p54867081.dip.t-dialin.net (EHLO debian) [84.134.112.129] by mail.gmx.net (mp021) with SMTP; 24 Jul 2008 07:35:40 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX19l0lMUexVl9pCWUPmZzj6W5snX0UgewWF+GPyaya U8/OO+ltupZ3BX In-Reply-To: <20080723185150.txs6e4gbr23ow0g4@webmail.mit.edu> (Chong Yidong's message of "Wed, 23 Jul 2008 18:51:50 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.62 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101369 Archived-At: On 2008-07-24 00:51 +0200, Chong Yidong wrote: > Regarding bug 268 in the bug tracker: > >> Copying a directory recursively in dired to a vfat partition fails >> because `dired-copy-file-recursive' calls `set-file-modes' on >> directories after creating them. This behaviour appears to be >> new in 22.2, same recursive copy worked in 22.1. > > This appears to be due to the following change: > > 2007-10-31 Sven Joachim > > * dired-aux.el (dired-copy-file-recursive): > Preserve directory permissions. > > Could someone fix this in both the trunk and the branch? > It looks like a simple condition-case around the call to > set-file-modes in dired-copy-file-recursive should be > enough; but someone with access to vfat needs to test this. I do have access to vfat, but I cannot reproduce the bug. IIRC there was some change in Linux 2.6.25 that caused the chmod call to report failure (it never works on vfat anyway, but that used to be silently ignored). This change seems to have been reverted in the meantime, though; I'm running 2.6.26 here. Sven