all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: emacs-devel@gnu.org
Subject: Re: Patch: goto-address minor modes
Date: Wed, 14 Jan 2009 02:27:16 +0200	[thread overview]
Message-ID: <87zlhuag0r.fsf@jurta.org> (raw)
In-Reply-To: <v93aqi3b2r.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Sat, 22 Mar 2008 18:47:24 +0100")

goto-address-mode is now a minor mode like bug-reference-mode.
bug-reference-mode uses the `link' face to highlight links,
but goto-address-mode still uses `bold'.  The following patch
changes address urls to be highlighted in the `link' face.
Also it takes a new minor mode into use in several places:

Index: lisp/net/goto-addr.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/net/goto-addr.el,v
retrieving revision 1.35
diff -u -r1.35 goto-addr.el
--- lisp/net/goto-addr.el	5 Jan 2009 03:22:44 -0000	1.35
+++ lisp/net/goto-addr.el	14 Jan 2009 00:21:07 -0000
@@ -129,7 +129,7 @@
     m)
   "Keymap to hold goto-addr's mouse key defs under highlighted URLs.")
 
-(defcustom goto-address-url-face 'bold
+(defcustom goto-address-url-face 'link
   "Face to use for URLs."
   :type 'face
   :group 'goto-address)

Index: etc/MORE.STUFF
===================================================================
RCS file: /sources/emacs/emacs/etc/MORE.STUFF,v
retrieving revision 1.73
diff -u -r1.73 MORE.STUFF
--- etc/MORE.STUFF	8 Jan 2009 05:11:57 -0000	1.73
+++ etc/MORE.STUFF	14 Jan 2009 00:21:35 -0000
@@ -270,7 +270,7 @@
 Local Variables:
 mode: text
 mode: view
-eval: (goto-address)
+mode: goto-address
 End:
 
 This file is part of GNU Emacs.

Index: lisp/help.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/help.el,v
retrieving revision 1.345
diff -u -r1.345 help.el
--- lisp/help.el	5 Jan 2009 03:19:17 -0000	1.345
+++ lisp/help.el	14 Jan 2009 00:23:37 -0000
@@ -294,7 +294,7 @@
 
 (defun view-help-file (file &optional dir)
   (view-file (expand-file-name file (or dir data-directory)))
-  (goto-address)
+  (goto-address-mode t)
   (goto-char (point-min)))
 
 (defun describe-distribution ()

Index: lisp/menu-bar.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/menu-bar.el,v
retrieving revision 1.349
diff -u -r1.349 menu-bar.el
--- lisp/menu-bar.el	13 Jan 2009 13:58:13 -0000	1.349
+++ lisp/menu-bar.el	14 Jan 2009 00:23:54 -0000
@@ -1492,7 +1492,7 @@
   (let (enable-local-variables)
     (view-file (expand-file-name "MORE.STUFF"
 				 data-directory))
-    (goto-address)))
+    (goto-address-mode t)))
 (define-key menu-bar-help-menu [sep2]
   '("--"))
 (define-key menu-bar-help-menu [external-packages]

-- 
Juri Linkov
http://www.jurta.org/emacs/




  reply	other threads:[~2009-01-14  0:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-06 16:33 Patch: goto-address minor modes Tom Tromey
2008-01-07 17:14 ` Richard Stallman
2008-01-07 16:59   ` Tom Tromey
2008-01-08 19:07     ` Richard Stallman
2008-03-22 17:47     ` Reiner Steib
2009-01-14  0:27       ` Juri Linkov [this message]
2009-01-14  3:25         ` Chong Yidong
2009-01-14  6:11         ` Dan Nicolaescu
2009-01-14  8:33           ` Lennart Borgman
2009-01-14 10:27             ` Juri Linkov
2009-01-14 15:30             ` Dan Nicolaescu
2009-01-14 20:11               ` Lennart Borgman
2009-01-14 21:21               ` Juri Linkov
2009-01-14 22:01                 ` Stefan Monnier
2009-01-14 23:55                   ` Juri Linkov
2009-01-15  0:25                   ` Lennart Borgman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zlhuag0r.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.