bug#6717: tramp-dissect-file-name: Not a Tramp file name

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[jidanni]

Recently, I have been getting this error:

error in process filter: tramp-dissect-file-name: Not a Tramp file name: /index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss
http://article.gmane.org/gmane.emacs.gnus.general/69788

Something changed in emacs that now causes me to be unable to read the
same feeds I used to be able to read.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

jidanni@jidanni.org writes:

> Recently, I have been getting this error:
>
> error in process filter: tramp-dissect-file-name: Not a Tramp file name: /index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss
> http://article.gmane.org/gmane.emacs.gnus.general/69788
>
> Something changed in emacs that now causes me to be unable to read the
> same feeds I used to be able to read.

It would be nice, if you could tell us emacs-version and tramp-version.

Futhermore, could you, please, set debug-on-error to non-nil, and show
the backtrace?

Thanks, and best regards, Michael.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[jidanni]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

emacs-version"24.0.50.1" <--too vague always
tramp-version"2.1.19-pre".
$ apt-cache policy emacs-snapshot 
emacs-snapshot:
  Installed: 1:20100724-1
  Candidate: 1:20100724-1
  Version table:
 *** 1:20100724-1 0
        500 http://emacs.orebokech.com sid/main Packages
        100 /var/lib/dpkg/status

[-- Attachment #2: backtrace full of control characters so I dare not just paste it --]
[-- Type: application/octet-stream, Size: 535 bytes --]

[-- Attachment #3: Type: text/plain, Size: 59 bytes --]

Config files all on http://jidanni.org/comp/configuration/

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[jidanni]

Hmmm, it is probably due to the link having changed,
old http://taizhongbus.wikia.com/index.php?title=特殊:近期變動&feed=rss
new http://taizhongbus.wikia.com/index.php?title=特殊:最近更改&feed=rss
But still, the error message should be more like the 404 Not Found the
old url gets...

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[jidanni]

Anyway, I try to subscribe to the new name,
http://taizhongbus.wikia.com/index.php?title=特殊:最近更改&feed=rss
but still I get

error in process filter: tramp-dissect-file-name: Not a Tramp file name: /index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss
error in process filter: Not a Tramp file name: /index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss
XML-RPC is not available... not checking Syndic8.
gnus-group-make-rss-group: No feeds found for http://radioscanningtw.wikia.com/index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[jidanni]

It turns out I was using the right url
http://taizhongbus.wikia.com/index.php?title=特殊:最近更改&feed=rss i.e.,
http://taizhongbus.wikia.com/index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss
all along. So the problem is tramp.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[jidanni]

The former two cause problems, but the latter three don't.
  http://radioscanningtw.wikia.com/index.php?title=特殊:最近更改&feed=rss
      http://taizhongbus.wikia.com/index.php?title=特殊:最近更改&feed=rss
    http://taizhongbus.jidanni.org/index.php?title=特殊:近期變動&feed=rss
http://radioscanningtw.jidanni.org/index.php?title=特殊:近期變動&feed=rss
     http://transgender-taiwan.org/index.php?title=特殊:近期變動&feed=rss
So either there is something allergic in the URL's UTF bytes, or it is the
Wikia.com response that is causing the problem. The HTTP HEADs are all
200 but slightly different.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

Thanks for the backtrace. The problem is the following line:

  file-name-directory("/index.php?title=%E7%89%B9%E6%AE%8A:%E6%9C%80%E8%BF%91%E6%9B%B4%E6%94%B9&feed=rss")

It checks the local file name part of your URL. Unfortunately, due to
the leading "/" and the ":", it looks like a Tramp file name from
syntactical point of view, but it isn't.

I have committed the following patch towards the Emacs-23 branch (which
will be synchronized with the trunk next days):

--8<---------------cut here---------------start------------->8---
*** /usr/local/src/emacs-23/lisp/url/url-http.el.~99941~	2010-07-25 16:24:26.568050862 +0200
--- /usr/local/src/emacs-23/lisp/url/url-http.el	2010-07-25 13:33:32.008050291 +0200
***************
*** 435,441 ****
  	(delete-process url-http-process)))))
    (let ((buffer (current-buffer))
  	(class nil)
! 	(success nil))
      (setq class (/ url-http-response-status 100))
      (url-http-debug "Parsed HTTP headers: class=%d status=%d" class url-http-response-status)
      (url-http-handle-cookies)
--- 435,444 ----
  	(delete-process url-http-process)))))
    (let ((buffer (current-buffer))
  	(class nil)
! 	(success nil)
! 	;; The filename part of a URL could be in remote file syntax,
! 	;; see Bug#6717 for an example.  We disable Tramp, therefore.
! 	(tramp-mode nil))
      (setq class (/ url-http-response-status 100))
      (url-http-debug "Parsed HTTP headers: class=%d status=%d" class url-http-response-status)
      (url-http-handle-cookies)
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Andreas Schwab]

Michael Albinus <michael.albinus@gmx.de> writes:

> --- 435,444 ----
>   	(delete-process url-http-process)))))
>     (let ((buffer (current-buffer))
>   	(class nil)
> ! 	(success nil)
> ! 	;; The filename part of a URL could be in remote file syntax,
> ! 	;; see Bug#6717 for an example.  We disable Tramp, therefore.
> ! 	(tramp-mode nil))

IMHO this is the wrong place to fix that.  Instead file-name-directory
should not be called on the local part in the first place, or at least
*all* file name handlers should be suppressed around the call.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> --- 435,444 ----
>>   	(delete-process url-http-process)))))
>>     (let ((buffer (current-buffer))
>>   	(class nil)
>> ! 	(success nil)
>> ! 	;; The filename part of a URL could be in remote file syntax,
>> ! 	;; see Bug#6717 for an example.  We disable Tramp, therefore.
>> ! 	(tramp-mode nil))
>
> IMHO this is the wrong place to fix that.  Instead file-name-directory
> should not be called on the local part in the first place, or at least
> *all* file name handlers should be suppressed around the call.

I thought about that. But I'm not sure, whether we shall disable
jka-compr, for example. What happens, if the URL is something like
http://host.cc/path/file.gz ?

I do not know url*.el sufficiently, that I could decide this ...

> Andreas.

Best regards, Michael.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Andreas Schwab]

Michael Albinus <michael.albinus@gmx.de> writes:

> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>> Michael Albinus <michael.albinus@gmx.de> writes:
>>
>>> --- 435,444 ----
>>>   	(delete-process url-http-process)))))
>>>     (let ((buffer (current-buffer))
>>>   	(class nil)
>>> ! 	(success nil)
>>> ! 	;; The filename part of a URL could be in remote file syntax,
>>> ! 	;; see Bug#6717 for an example.  We disable Tramp, therefore.
>>> ! 	(tramp-mode nil))
>>
>> IMHO this is the wrong place to fix that.  Instead file-name-directory
>> should not be called on the local part in the first place, or at least
>> *all* file name handlers should be suppressed around the call.
>
> I thought about that. But I'm not sure, whether we shall disable
> jka-compr, for example. What happens, if the URL is something like
> http://host.cc/path/file.gz ?

Nothing special.  Why should it?  It's not a file name, it is a URL.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

Andreas Schwab <schwab@linux-m68k.org> writes:

>>> IMHO this is the wrong place to fix that.  Instead file-name-directory
>>> should not be called on the local part in the first place, or at least
>>> *all* file name handlers should be suppressed around the call.
>>
>> I thought about that. But I'm not sure, whether we shall disable
>> jka-compr, for example. What happens, if the URL is something like
>> http://host.cc/path/file.gz ?
>
> Nothing special.  Why should it?  It's not a file name, it is a URL.

Maybe. But at least `url-file-handler' must be kept, it treats the URL
as a file name.

Another approach would be to encode ":" in the filename part of a URL,
but I don't know where to do it sufficiently.

> Andreas.

Best regards, Michael.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Andreas Schwab]

Michael Albinus <michael.albinus@gmx.de> writes:

> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>>>> IMHO this is the wrong place to fix that.  Instead file-name-directory
>>>> should not be called on the local part in the first place, or at least
>>>> *all* file name handlers should be suppressed around the call.
>>>
>>> I thought about that. But I'm not sure, whether we shall disable
>>> jka-compr, for example. What happens, if the URL is something like
>>> http://host.cc/path/file.gz ?
>>
>> Nothing special.  Why should it?  It's not a file name, it is a URL.
>
> Maybe. But at least `url-file-handler' must be kept, it treats the URL
> as a file name.

Why? There is no url-file-name-directory.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>
>>>>> IMHO this is the wrong place to fix that.  Instead file-name-directory
>>>>> should not be called on the local part in the first place, or at least
>>>>> *all* file name handlers should be suppressed around the call.
>>>>
>>>> I thought about that. But I'm not sure, whether we shall disable
>>>> jka-compr, for example. What happens, if the URL is something like
>>>> http://host.cc/path/file.gz ?
>>>
>>> Nothing special.  Why should it?  It's not a file name, it is a URL.
>>
>> Maybe. But at least `url-file-handler' must be kept, it treats the URL
>> as a file name.
>
> Why? There is no url-file-name-directory.

Indeed. But you don't know, which other primitive functions are called,
requesting a url-* handler. And you don't know, whether
url-file-name-directory will be added to url-handlers.el in the future.

At least I don't know. If there shall be another fix than disabling
Tramp temporarily, I would like to give it to somebody else with much
more knowledge about the url package than I have.

> Andreas.

Best regards, Michael.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Andreas Schwab]

Michael Albinus <michael.albinus@gmx.de> writes:

> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>> Michael Albinus <michael.albinus@gmx.de> writes:
>>
>>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>>
>>>>>> IMHO this is the wrong place to fix that.  Instead file-name-directory
>>>>>> should not be called on the local part in the first place, or at least
>>>>>> *all* file name handlers should be suppressed around the call.
>>>>>
>>>>> I thought about that. But I'm not sure, whether we shall disable
>>>>> jka-compr, for example. What happens, if the URL is something like
>>>>> http://host.cc/path/file.gz ?
>>>>
>>>> Nothing special.  Why should it?  It's not a file name, it is a URL.
>>>
>>> Maybe. But at least `url-file-handler' must be kept, it treats the URL
>>> as a file name.
>>
>> Why? There is no url-file-name-directory.
>
> Indeed. But you don't know, which other primitive functions are called,
> requesting a url-* handler.

??? We are talking about file-name-directory.

> And you don't know, whether url-file-name-directory will be added to
> url-handlers.el in the future.

Even then, it will not be called because the argument does not match the
syntax of a URL, since it's only the local part of it.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

Andreas Schwab <schwab@linux-m68k.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>
>>> Michael Albinus <michael.albinus@gmx.de> writes:
>>>
>>>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>>>
>>>>>>> IMHO this is the wrong place to fix that.  Instead file-name-directory
>>>>>>> should not be called on the local part in the first place, or at least
>>>>>>> *all* file name handlers should be suppressed around the call.
>>>>>>
>>>>>> I thought about that. But I'm not sure, whether we shall disable
>>>>>> jka-compr, for example. What happens, if the URL is something like
>>>>>> http://host.cc/path/file.gz ?
>>>>>
>>>>> Nothing special.  Why should it?  It's not a file name, it is a URL.
>>>>
>>>> Maybe. But at least `url-file-handler' must be kept, it treats the URL
>>>> as a file name.
>>>
>>> Why? There is no url-file-name-directory.
>>
>> Indeed. But you don't know, which other primitive functions are called,
>> requesting a url-* handler.
>
> ??? We are talking about file-name-directory.

I believe, such a mis-handling of the URL file name part can happen
somewhere else as well. So a more general solution might be useful.

For the concrete location of my patch you might be right. Let-bind of
file-name-handler-alist to nil should do the job as well.

> Andreas.

Best regards, Michael.

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Andreas Schwab]

Michael Albinus <michael.albinus@gmx.de> writes:

> I believe, such a mis-handling of the URL file name part can happen
> somewhere else as well.

They should be fixed as well.

> So a more general solution might be useful.

But it will only hide the real problem.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#6717: tramp-dissect-file-name: Not a Tramp file name

[Michael Albinus]

Andreas Schwab <schwab@linux-m68k.org> writes:

>> So a more general solution might be useful.
>
> But it will only hide the real problem.

I've reworked the patch as proposed by you.

> Andreas.

Best regards, Michael.