From: Matt Lundin <mdl@imapmail.org>
To: Eric S Fraga <e.fraga@ucl.ac.uk>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>,
Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: Re: Including current time in agenda
Date: Sun, 12 Dec 2010 16:31:06 -0500 [thread overview]
Message-ID: <87zksa3ch1.fsf@fastmail.fm> (raw)
In-Reply-To: <871v5m27y4.fsf@ucl.ac.uk> (Eric S. Fraga's message of "Sun, 12 Dec 2010 17:54:11 +0000")
Eric S Fraga <e.fraga@ucl.ac.uk> writes:
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
> [...]
>
>> I agree that this is creative and great.
>>
>> However having the current time in the time grid is so useful that
>> I have now made it the default, no diary sexp needed.
>
> Thanks for this, Carsten. I like being able to change the face easily
> (in my case, I simply set it to underline with no agenda string to keep
> a minimalist approach).
>
> However, there is one problem (?): if I change my view to another day
> (using, say, "j" in the agenda day view), I get the "current time"
> highlighted for that other day and obviously the current time makes no
> sense other than for "today", I would argue.
The patch below fixes the issue for me.
Best,
Matt
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index fb26ee9..67c8d89 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5353,7 +5353,7 @@ The modified list may contain inherited tags, and tags matched by
new)
(put-text-property
2 (length (car new)) 'face 'org-time-grid (car new))))
- (when org-agenda-show-current-time-in-grid
+ (when (and todayp org-agenda-show-current-time-in-grid)
(push (org-format-agenda-item
nil
org-agenda-current-time-string
--8<---------------cut here---------------end--------------->8---
next prev parent reply other threads:[~2010-12-12 21:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 6:49 Including current time in agenda suvayu ali
2010-12-06 11:47 ` Eric S Fraga
2010-12-06 11:55 ` suvayu ali
2010-12-06 12:08 ` Eric S Fraga
2010-12-06 12:27 ` suvayu ali
2010-12-06 13:00 ` Carsten Dominik
2010-12-06 13:10 ` suvayu ali
2010-12-06 13:38 ` Julien Danjou
2010-12-06 14:03 ` Carsten Dominik
2010-12-06 14:30 ` Suvayu Ali
2010-12-06 14:45 ` Carsten Dominik
2010-12-06 14:53 ` Suvayu Ali
2010-12-06 14:56 ` Carsten Dominik
2010-12-06 14:59 ` Rémi Vanicat
2010-12-06 15:10 ` suvayu ali
2010-12-06 15:13 ` Julien Danjou
2010-12-06 15:28 ` Suvayu Ali
2010-12-06 15:39 ` Matt Lundin
2010-12-12 8:30 ` Carsten Dominik
2010-12-12 17:54 ` Eric S Fraga
2010-12-12 21:31 ` Matt Lundin [this message]
2011-01-07 19:31 ` Erik Butz
2011-01-07 23:27 ` suvayu ali
2011-01-07 23:46 ` Erik Butz
2011-01-08 0:04 ` suvayu ali
2011-01-08 14:46 ` Erik Butz
2010-12-12 18:19 ` suvayu ali
2010-12-06 19:27 ` Eric S Fraga
2010-12-06 22:34 ` suvayu ali
2010-12-08 23:46 ` [PATCH] sexp can set its face (was: Including current time in agenda) Łukasz Stelmach
2010-12-12 7:44 ` Carsten Dominik
2010-12-13 0:14 ` suvayu ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zksa3ch1.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=carsten.dominik@gmail.com \
--cc=e.fraga@ucl.ac.uk \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.