Re: switch-to-buffer: for interactive use only

[Chong Yidong <cyd@stupidchicken.com>]

Juanma Barranquero <lekktu@gmail.com> writes:

>> So, if creating a new window is the wrong thing for bs-cycle-next, it
>> should be bs-cycle-next that changes---e.g. by changing from
>> switch-to-buffer to set-window-buffer---not everything else in Emacs.
>
> I don't remember saying that it is the rest of Emacs which must be
> changed; only that there are two different use cases, and we must
> cater to both.

Fair enough.  So, I propose the following:

- Make switch-to-buffer basically do
  (pop-to-buffer buffer-or-name 'same-window norecord label)

- Make pop-to-buffer-same-window an alias for switch-to-buffer.
  (This means to add an optional LABEL arg to switch-to-buffer, for
  consistency with pop-to-buffer-same-window.)

- Remove the "interactive use only" flag from switch-to-buffer.

- For those places that intend the "act on the selected window"
  behavior---which is the minority---change the code to call
  (set-window-buffer (selected-window) buffer), instead of
  switch-to-buffer.

How's that?