From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10053: Wrong use of minibuffer-completion-table in tmm-add-prompt Date: Wed, 16 Nov 2011 09:27:49 +0100 Message-ID: <87zkfwwjy2.fsf@gmail.com> References: <8739dpzmz3.fsf@gmail.com> <87fwhp2hko.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1321432108 24875 80.91.229.12 (16 Nov 2011 08:28:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 16 Nov 2011 08:28:28 +0000 (UTC) Cc: 10053@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 16 09:28:24 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RQar1-0006St-NA for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2011 09:28:23 +0100 Original-Received: from localhost ([::1]:40257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQar1-0005xz-5Q for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2011 03:28:23 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:53294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQaqx-0005pN-Ry for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 03:28:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQaqw-0006B3-Mb for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 03:28:19 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQaqw-0006Az-J4 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 03:28:18 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RQard-0002KT-W1 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 03:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2011 08:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10053 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10053-submit@debbugs.gnu.org id=B10053.13214321298929 (code B ref 10053); Wed, 16 Nov 2011 08:29:01 +0000 Original-Received: (at 10053) by debbugs.gnu.org; 16 Nov 2011 08:28:49 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQarQ-0002Jx-Kd for submit@debbugs.gnu.org; Wed, 16 Nov 2011 03:28:48 -0500 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQarL-0002Jh-Eq for 10053@debbugs.gnu.org; Wed, 16 Nov 2011 03:28:46 -0500 Original-Received: by bkbzv15 with SMTP id zv15so269951bkb.3 for <10053@debbugs.gnu.org>; Wed, 16 Nov 2011 00:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=5aM+9vBPTAfLfkGOvZ0KtEbbnATFsBtpRurrVWt+V88=; b=gfXv6LIxOhRVU3wKQAeJU6dOpBHWUCIdIS4A6cM7k4vz1bWAHIexr1t3m3ETXLshAM n5RjXrD4o0u3YhNi4BT0i1+kVpK4KRuaDWhma64j31r8O7KRlfZgL9uB6s09binfwHgV XS/mi/idyHGMt4CORO0k7cRBzLYzL7ES1PeHE= Original-Received: by 10.204.9.211 with SMTP id m19mr27259676bkm.92.1321432073473; Wed, 16 Nov 2011 00:27:53 -0800 (PST) Original-Received: from thierry-MM061 (56.78.88.79.rev.sfr.net. [79.88.78.56]) by mx.google.com with ESMTPS id e20sm4764740fab.2.2011.11.16.00.27.50 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Nov 2011 00:27:52 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Tue, 15 Nov 2011 21:26:17 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 16 Nov 2011 03:29:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53979 Archived-At: Stefan Monnier writes: > But the error is that tmm-add-prompt should not be run in that case. > It should only be run when you use tmm-prompt or tmm-menubar. Yes, but when calling `menu-bar-open' with menu-bar-mode==nil, it calls `x-menu-bar-open' which calls `tmm-menubar' right? And in my case here `tmm-add-prompt' is called and error occur. I think it would be safer to check if `minibuffer-completion-table' is a table or a (a)list, and run the appropriate code to handle both cases. Though `all-completions' can handle both cases here i think. I still not understand the purpose of `tmm-add-prompt', what does it want to complete here? A list of buffers? Why? > I see a small error in tmm.el which could explain why tmm-add-prompt > lingers on minibuffer-setup-hook longer than desired. I've installed the > patch below, please see if it helps. Your patch works with `anything-completion-mode' disabled, but as soon i turn it on, `tmm-add-prompt' is called and same error occur: --8<---------------cut here---------------start------------->8--- Debugger entered--Lisp error: (wrong-type-argument listp closure) car(closure) mapcar(car (closure (t) (&rest args) [...] tmm-add-prompt() --8<---------------cut here---------------end--------------->8--- `anything-completion-mode' is only using his own `completing-read-function'. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997