From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Sun, 15 Jan 2012 22:01:45 +0100 Message-ID: <87zkdoissm.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <8362ggkquq.fsf@gnu.org> <87lipcrlga.fsf@gmail.com> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> <87fwfjo24c.fsf@gmx.de> <87pqen76p4.fsf@gmail.com> <83fwfik92e.fsf@gnu.org> <87mx9q1sz7.fsf@gmail.com> <87vcodm8ns.fsf@gmx.de> <87pqekopb5.fsf@gmail.com> <87hazwoost.fsf@gmail.com> <87ty3w9639.fsf@gmx.de> <8762gckckt.fsf@gmail.com> <87pqek9269.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326661342 14858 80.91.229.12 (15 Jan 2012 21:02:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 15 Jan 2012 21:02:22 +0000 (UTC) To: 10489@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 15 22:02:18 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RmXDV-0000ET-VY for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jan 2012 22:02:18 +0100 Original-Received: from localhost ([::1]:55044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmXDV-0001wg-A3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jan 2012 16:02:17 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmXDS-0001wY-CZ for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:02:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmXDQ-0006bU-HK for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:02:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmXDQ-0006b8-Fo for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:02:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RmXED-0008N9-V8 for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:03:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87mx9su32g.fsf@web.de> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jan 2012 21:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.132666138032175 (code B ref -1); Sun, 15 Jan 2012 21:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2012 21:03:00 +0000 Original-Received: from localhost ([127.0.0.1]:58931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmXEB-0008Mu-Km for submit@debbugs.gnu.org; Sun, 15 Jan 2012 16:02:59 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:46902) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmXE8-0008Mn-Q6 for submit@debbugs.gnu.org; Sun, 15 Jan 2012 16:02:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmXDJ-0006a0-Ff for submit@debbugs.gnu.org; Sun, 15 Jan 2012 16:02:06 -0500 Original-Received: from lists.gnu.org ([140.186.70.17]:49648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmXDJ-0006Zw-E1 for submit@debbugs.gnu.org; Sun, 15 Jan 2012 16:02:05 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmXDG-0001w8-Qh for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:02:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmXDF-0006ZC-TS for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:02:02 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:56716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmXDF-0006Z4-Gg for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 16:02:01 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RmXDD-00008b-Mu for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2012 22:01:59 +0100 Original-Received: from 5.78.88.79.rev.sfr.net ([79.88.78.5]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Jan 2012 22:01:59 +0100 Original-Received: from thierry.volpiatto by 5.78.88.79.rev.sfr.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Jan 2012 22:01:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 5.78.88.79.rev.sfr.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) Cancel-Lock: sha1:ZmqhUUinwCafbeNnrV9haPNt8Ko= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55776 Archived-At: Michael Albinus writes: > Thierry Volpiatto writes: > >> IMHO we should fix this bug for most use cases with a compare function >> maybe not perfect in many points but ok for most basic usages. >> The function shown by Drew and I put in last patch as you said isn't >> sufficient and fail in many cases even on local filesystem: >> >> (defun bmkp-same-file-p (file1 file2) >> "Return non-nil if FILE1 and FILE2 name the same file. >> If either name is not absolute, then it is expanded relative to >> `default-directory' for the test." >> (and (equal (file-remote-p file1) (file-remote-p file2)) >> (string= (file-truename (expand-file-name file1)) >> (file-truename (expand-file-name file2))))) >> >> (bmkp-same-file-p "~/Test" "/home/thierry/Test/") => nil > > So it must be > > (string= (directory-file-name (file-truename (expand-file-name file1))) > (directory-file-name (file-truename (expand-file-name file2)))))) Of course, thanks. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997