From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#11747: 24.1.50; called-interactively-p vs. advice Date: Mon, 25 Jun 2012 19:54:21 +0200 Message-ID: <87zk7r5lbm.fsf@web.de> References: <87lijj9n8t.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1340646796 15220 80.91.229.3 (25 Jun 2012 17:53:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2012 17:53:16 +0000 (UTC) Cc: 11747@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 25 19:53:15 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjDTO-0006eG-Go for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jun 2012 19:53:14 +0200 Original-Received: from localhost ([::1]:43692 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjDTO-0001zM-J5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jun 2012 13:53:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjDTL-0001ys-M1 for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2012 13:53:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjDTG-0000xm-Nl for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2012 13:53:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjDTG-0000xb-KH for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2012 13:53:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SjDX4-0001Mq-0g for bug-gnu-emacs@gnu.org; Mon, 25 Jun 2012 13:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jun 2012 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11747 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11747-submit@debbugs.gnu.org id=B11747.13406469745203 (code B ref 11747); Mon, 25 Jun 2012 17:57:01 +0000 Original-Received: (at 11747) by debbugs.gnu.org; 25 Jun 2012 17:56:14 +0000 Original-Received: from localhost ([127.0.0.1]:57530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjDWH-0001Ls-TC for submit@debbugs.gnu.org; Mon, 25 Jun 2012 13:56:14 -0400 Original-Received: from mout.web.de ([212.227.17.12]:59893) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjDWF-0001Lk-Vu for 11747@debbugs.gnu.org; Mon, 25 Jun 2012 13:56:12 -0400 Original-Received: from snow.dragon ([89.204.138.131]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0MC1ho-1SaNli2rI0-009cJi; Mon, 25 Jun 2012 19:52:11 +0200 In-Reply-To: (Glenn Morris's message of "Sun, 24 Jun 2012 21:14:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-Provags-ID: V02:K0:nGcEMKWcd2sOLzQOJds9kpnIuSeiwNF3oIYlUPwEadc FSefCwvlhQzEgl56XuHcqDGyMSISF2YAyE9TQMb+D0VxXRlfux vWfnqFWHjTUJVlNY7Tt4Fb/J7AMOdKYrwmwAaLKbeghLp17W6Q ttsErEA3xU0tcqrYJ3q5KPUHwbM5zJ8dNo+BDTW4kiC2FZrzrr HxZQlM94eJTargNbiw7+w7+fsYOoBw51AT9HsSieCI= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61279 Archived-At: Glenn Morris writes: > > `called-interactively-p' returns wrong values when called inside > > commands that are adviced. > > Old "interactive-p" had the same issue, though maybe that mattered less. > It's to do with the way advice is implemented. It actually goes out of > its way to avoid using call-interactively unless it has to (subrs). > See comments in advice.el header. So, do you mean this can't be fixed? Too bad, but ok, that's what I thought. But then, we IMHO should improve the docstring of `called-interactively': 1. This sentence: This function is meant for implementing advice and other function-modifying features. Is there a "not" missing? 2. Explicitly say that `called-interactively' will not work when used in an adviced function. This is something completely different than 1. 1. is about implementing advice via `called-interactively'. 2. says that if you advice any function that already uses it, it will stop working. So, my wish is to improve the docstring of `called-interactively' a bit. Then, this report can be closed. Michael.