From: Michael Heerdegen <michael_heerdegen@web.de>
To: Glenn Morris <rgm@gnu.org>
Cc: 11747@debbugs.gnu.org
Subject: bug#11747: 24.1.50; called-interactively-p vs. advice
Date: Mon, 25 Jun 2012 19:54:21 +0200 [thread overview]
Message-ID: <87zk7r5lbm.fsf@web.de> (raw)
In-Reply-To: <bi395kp4z4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 24 Jun 2012 21:14:55 -0400")
Glenn Morris <rgm@gnu.org> writes:
> > `called-interactively-p' returns wrong values when called inside
> > commands that are adviced.
>
> Old "interactive-p" had the same issue, though maybe that mattered less.
> It's to do with the way advice is implemented. It actually goes out of
> its way to avoid using call-interactively unless it has to (subrs).
> See comments in advice.el header.
So, do you mean this can't be fixed? Too bad, but ok, that's what I
thought.
But then, we IMHO should improve the docstring of `called-interactively':
1. This sentence:
This function is meant for implementing advice and other
function-modifying features.
Is there a "not" missing?
2. Explicitly say that `called-interactively' will not work when used
in an adviced function.
This is something completely different than 1. 1. is about implementing
advice via `called-interactively'. 2. says that if you advice any
function that already uses it, it will stop working.
So, my wish is to improve the docstring of `called-interactively' a bit.
Then, this report can be closed.
Michael.
next prev parent reply other threads:[~2012-06-25 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 18:21 bug#11747: 24.1.50; called-interactively-p vs. advice Michael Heerdegen
2012-06-25 1:14 ` Glenn Morris
2012-06-25 17:54 ` Michael Heerdegen [this message]
2012-06-25 23:40 ` Glenn Morris
2013-02-08 22:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk7r5lbm.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=11747@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.