From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#12159: 24.1.50; vc-dir: Need a way to hide unregistered files Date: Mon, 13 Aug 2012 00:41:00 +0530 Message-ID: <87zk60hqnv.fsf@gmail.com> References: <87pq71i7fy.fsf@gmail.com> <87d3312p4f.fsf@gmail.com> <871ujdpbqp.fsf@gmail.com> <87boigj2ti.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1344798706 15813 80.91.229.3 (12 Aug 2012 19:11:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 12 Aug 2012 19:11:46 +0000 (UTC) Cc: 12159@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 12 21:11:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T0dZb-0002jG-KF for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Aug 2012 21:11:39 +0200 Original-Received: from localhost ([::1]:57465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0dZa-0005Xm-L5 for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Aug 2012 15:11:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0dZX-0005Xg-Os for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 15:11:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0dZW-00069P-Ma for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 15:11:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0dZW-00069H-JL for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 15:11:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T0dhi-0001xX-2b for bug-gnu-emacs@gnu.org; Sun, 12 Aug 2012 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Aug 2012 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12159 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12159-submit@debbugs.gnu.org id=B12159.13447991667484 (code B ref 12159); Sun, 12 Aug 2012 19:20:01 +0000 Original-Received: (at 12159) by debbugs.gnu.org; 12 Aug 2012 19:19:26 +0000 Original-Received: from localhost ([127.0.0.1]:51663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T0dh7-0001wf-Va for submit@debbugs.gnu.org; Sun, 12 Aug 2012 15:19:26 -0400 Original-Received: from mail-pb0-f44.google.com ([209.85.160.44]:59646) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T0dh5-0001wW-KC for 12159@debbugs.gnu.org; Sun, 12 Aug 2012 15:19:24 -0400 Original-Received: by pbbrr4 with SMTP id rr4so7838576pbb.3 for <12159@debbugs.gnu.org>; Sun, 12 Aug 2012 12:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=g/+IQl4mPgeivRPm3j8bIITpHQUzVAQhxZV36HmrvIQ=; b=SXtqxI6taFHFF/c1lg9qoUIiIYbhgtVD5YgDqCmuo+f3qD2Em2UWTgBPa4bhfejoL8 Jql39TqCIWtD3hSO3lNu6KirS6C9PqBtpksmjwaB4sT9wNlmx04Zs85tm6W34IYhhZxH DaVe3BU0V9N47XIC5JSUW9RUeRbKIj1cSPU/7XCeA+lM2F3G0klEVHZda/y1GKs38nmQ xf+a9BpeZie21sFznRpsx04f1HQEXaJ2coUvxC9bNvGp1JKs1PrNkmY1Nqat0ILM2H7N Ufvl6EdC9qPp2xoNJzpoDc3Hy8TdyU36Iy3lVaV4fdMya4UE7EfZnukoJnzOYdPyvGAw +XDQ== Original-Received: by 10.68.203.200 with SMTP id ks8mr15748833pbc.142.1344798654710; Sun, 12 Aug 2012 12:10:54 -0700 (PDT) Original-Received: from debian-6.05 ([101.62.48.22]) by mx.google.com with ESMTPS id qn3sm3779009pbc.6.2012.08.12.12.10.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 12 Aug 2012 12:10:53 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 12 Aug 2012 10:13:05 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63078 Archived-At: I wish reviewers provide feedback which is comprehensive right from the word go. Let me explain ... When I submitted my patch it was complete i.e., I did not present it hunk-by-hunk. I re-worked the patch based on feedback and I have demonstrated some seriousness in making the patch acceptable. Unfortunately, the review process here seems to have gone by "hunk by hunk" mode. A small note here, a small note there. For something as simple as this patch, why should we have 100 exchanges? I can't care less if you call my patch a crap or hold an opinion that I should never enter a programmer's territory. It is not what I am talking about. Reviewers have infinite time to review the patch. Let them collect their notes and give a comprehensive list of what they think is acceptable to them. I hope I am not placing an un-reasonable demand. We are talking of an implicit social contract that reviewers and patch submitters should adhere to. Unfortunately, it is only the patch submitters end of the contract that gets much emphasis. Jambunathan K. >> + * vc/vc-dir.el (vc-dir-hide-these-states): New custom variable. > > Don't bother. Just always default to up-to-date. > >> +(defun vc-dir-hide-some-states (&optional states) > > Make it `state' and not a list. > >> + (interactive >> + ;; Interactive use. > > Redundant comment. > >> + ;; Non-interactive use. >> + (unless (called-interactively-p 'any) >> + (setq states (or states vc-dir-hide-these-states))) > > The test is wrong (it prevents non-interactive use where you specify > the state explicitly). > The above should simply be (unless state (setq state 'up-to-date)). > >> +(defun vc-dir-hide-up-to-date () >> + "Hide up-to-date items from display." >> + (interactive) >> + (vc-dir-hide-some-states '("up-to-date"))) > > Why bother? > > > Stefan