all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: 13242@debbugs.gnu.org
Subject: bug#13242: 24.2.91; dired-goto-file: read-file-name with nil MUSTMATCH
Date: Thu, 20 Dec 2012 18:08:58 +0100	[thread overview]
Message-ID: <87zk18lkgl.fsf@bzg.ath.cx> (raw)
In-Reply-To: <871ueku08c@ch.ristopher.com> (Christopher Schmidt's message of "Thu, 20 Dec 2012 17:01:14 +0000 (GMT)")

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Christopher Schmidt <christopher@ch.ristopher.com> writes:

> The interactive form of dired-goto-file reads a file name using
> read-file-name.  Arg MUSMATCH of this call is nil, though.  This does
> not make sense to me.  I think this arg should be t.

Agreed.  This trivial patch does this.

This is not really a bug to me, so I'm not sure if this should go
to emacs-24 or to trunk.  I'll let another maintainer decide on this.

Thanks,


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dired.el.patch --]
[-- Type: text/x-patch, Size: 460 bytes --]

=== modified file 'lisp/dired.el'
--- lisp/dired.el	2012-11-23 07:59:43 +0000
+++ lisp/dired.el	2012-12-20 17:07:30 +0000
@@ -2623,7 +2623,7 @@
    (prog1				; let push-mark display its message
        (list (expand-file-name
 	      (read-file-name "Goto file: "
-			      (dired-current-directory))))
+			      (dired-current-directory) nil t)))
      (push-mark)))
   (unless (file-name-absolute-p file)
     (error "File name `%s' is not absolute" file))


[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

      parent reply	other threads:[~2012-12-20 17:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 17:01 bug#13242: 24.2.91; dired-goto-file: read-file-name with nil MUSTMATCH Christopher Schmidt
2012-12-20 17:06 ` Andreas Schwab
2012-12-20 17:10   ` Bastien
2012-12-20 17:27     ` Andreas Schwab
2012-12-20 17:36       ` Bastien
2012-12-20 17:15   ` Christopher Schmidt
2020-08-25 12:00   ` Lars Ingebrigtsen
2012-12-20 17:08 ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk18lkgl.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=13242@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.