From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#4533: 23.1: reverting fails to update line ending mode line Date: Sun, 10 Feb 2013 11:09:51 +0800 Message-ID: <87zjzc3lvk.fsf@gnu.org> References: <1afaf6160909221901p527cca80jcbf81e589cde629d@mail.gmail.com> <87mxpcc115.fsf@stupidchicken.com> <87bp5qbipg.fsf@stupidchicken.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360465871 19050 80.91.229.3 (10 Feb 2013 03:11:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Feb 2013 03:11:11 +0000 (UTC) Cc: 4533-done@debbugs.gnu.org, Kenichi Handa To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 10 04:11:31 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U4NKB-0006fJ-0Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Feb 2013 04:11:27 +0100 Original-Received: from localhost ([::1]:46695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4NJr-0003VJ-Bp for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Feb 2013 22:11:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4NJm-0003Ux-S1 for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 22:11:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U4NJg-0001gU-0T for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 22:11:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U4NJf-0001gP-S8 for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 22:10:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U4NJp-0000fO-Nz for bug-gnu-emacs@gnu.org; Sat, 09 Feb 2013 22:11:07 -0500 Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Feb 2013 03:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 4533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 4533@debbugs.gnu.org, cyd@gnu.org, benjamin@python.org Original-Received: via spool by 4533-done@debbugs.gnu.org id=D4533.13604658312514 (code D ref 4533); Sun, 10 Feb 2013 03:11:02 +0000 Original-Received: (at 4533-done) by debbugs.gnu.org; 10 Feb 2013 03:10:31 +0000 Original-Received: from localhost ([127.0.0.1]:47688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4NIv-0000e5-Kz for submit@debbugs.gnu.org; Sat, 09 Feb 2013 22:10:26 -0500 Original-Received: from mail-pb0-f41.google.com ([209.85.160.41]:45094) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U4NIr-0000dv-Vl for 4533-done@debbugs.gnu.org; Sat, 09 Feb 2013 22:10:07 -0500 Original-Received: by mail-pb0-f41.google.com with SMTP id um15so267033pbc.14 for <4533-done@debbugs.gnu.org>; Sat, 09 Feb 2013 19:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=PxZNu2Akyd3KCa8on74xmf5W7i2kyMQEQZ5GtqJngyI=; b=PzD5T9G1Hf6MYi9PfortxgsaRi4aPVFkmnU1waWLHKKqt5H5d7jrJulSr3U1f7b1yA o0aa9t9NU7O0Udo8tIgUYJRRmsM4gdk88ZNnAwjZYyti89idLYptKCXOztBFMKDMAfJI K2dkWM7IG7eLacNmPCWL+QS4HIaAnjCLyY9h2sZ/KkDMCcXAlsYLk0sADK5gF+8/SOci i9H9h9L5ul8JcXKdiJkL6RHTgcMWa4c6s8GUOTMqgeyHZv2VrH2VRRI3D2Eulw6oTHUb Ce4iit/IijBl9oOwkPoxB22WKCtellPyEQIhNU+gtEoK3XJ+sFe0Z8cI/8ZewlLAveaB 1WmQ== X-Received: by 10.68.197.131 with SMTP id iu3mr7627608pbc.72.1360465793090; Sat, 09 Feb 2013 19:09:53 -0800 (PST) Original-Received: from tsparkle (cm126.delta178.maxonline.com.sg. [59.189.178.126]) by mx.google.com with ESMTPS id xg1sm3190641pbc.26.2013.02.09.19.09.49 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 09 Feb 2013 19:09:51 -0800 (PST) In-Reply-To: <87bp5qbipg.fsf@stupidchicken.com> (Chong Yidong's message of "Mon, 15 Nov 2010 12:27:39 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70983 Archived-At: Chong Yidong writes: >> So maybe the problem is that C-x C-s should not set >> buffer-file-coding-system-explicit (unless the C-x C-s prompted the user >> to choose a coding-system, I guess). > > I see. The comments in mule.el say that > > ;; This variable is set in these three cases: > ;; (1) A file is read by a coding system specified explicitly. > ;; after-insert-file-set-coding sets the car of this value to > ;; coding-system-for-read, and sets the cdr to nil. > ;; (2) A buffer is saved. > ;; After writing, basic-save-buffer-1 sets the car of this value > ;; to last-coding-system-used. > ;; (3) set-buffer-file-coding-system is called. > ;; The cdr of this value is set to the specified coding system. > ;; This variable is used for decoding in revert-buffer and encoding in > ;; select-safe-coding-system. > > Indeed, this seems to imply that (2) can be omitted, as you suggest, > since "force selecting" a coding system should trigger (1) and (3). Is > there any reason that (2) was originally included? Since there's been no response, and my testing showed no ill effects to this change, I went ahead and committed it in the trunk. Let's see how it shakes out.