all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@gnu.org>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Re: running each test file independently in test/automated
Date: Tue, 17 Sep 2013 22:00:44 +0900	[thread overview]
Message-ID: <87zjrb7gcj.fsf@gnu.org> (raw)
In-Reply-To: <CAFM41H3JOzvyOUf_eRYj+MmD3X4f6n8-qohGpzyZRwm-FacHgw@mail.gmail.com> (message from Barry OReilly on Mon, 16 Sep 2013 11:54:22 -0400)

In article <CAFM41H3JOzvyOUf_eRYj+MmD3X4f6n8-qohGpzyZRwm-FacHgw@mail.gmail.com>, Barry OReilly <gundaetiapo@gmail.com> writes:

> > We have to catch an error of byte-compilation,

> To what end? The individual can see build errors and I presume Hydra
> reports build failures originating in the Makefile.

Ah, "have to" was too strong, but it is more convenient that
the whole testing doesn't stop by an error of a single test
file.

> > but there already exists this target and rule, and I'd like not to
> > change the original behavior.

> Doing in ert.el what the Makefile is responsible for seems off to me.

I agree with that.  If we don't have to keep the original
behavior of "make check", let's modify the rule of
".el.elc:".

> If test code build errors are to go in the summary, why shouldn't
> build errors of the code under test? If incorporating build failures
> into a summary report is good enough to do, why isn't it good enough
> for 'make check'?

Sorry but I don't understand what you want to say.

---
Kenichi Handa
handa@gnu.org



  reply	other threads:[~2013-09-17 13:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-15 20:04 [PATCH] Re: running each test file independently in test/automated Barry OReilly
2013-09-16 12:26 ` Kenichi Handa
2013-09-16 15:54   ` Barry OReilly
2013-09-17 13:00     ` Kenichi Handa [this message]
2013-09-17 13:47       ` Barry OReilly
2013-09-19 14:57         ` Kenichi Handa
2013-09-19 21:18   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjrb7gcj.fsf@gnu.org \
    --to=handa@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gundaetiapo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.