all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleh <oleh.krehel@gmail.com>
To: 15587@debbugs.gnu.org
Subject: bug#15587: [PATCH] Edebug `destructuring-bind' dotted spec
Date: Fri, 11 Oct 2013 12:39:37 +0200	[thread overview]
Message-ID: <87zjqg9jme.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

Hi,

Currently it's not possible to edebug

(defun foo (z)
  (destructuring-bind (x . y) z (+ x y)))

I attach a small patch to fix this.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emacs-lisp-cl-macs.el-cl-destructuring-bind-added-do.patch --]
[-- Type: text/x-diff, Size: 1178 bytes --]

From 51a191c06f210eecf594be384e9b835afb9a818f Mon Sep 17 00:00:00 2001
From: Oleh Krehel <ohwoeowho@gmail.com>
Date: Fri, 11 Oct 2013 12:34:03 +0200
Subject: [PATCH] * emacs-lisp/cl-macs.el: (cl-destructuring-bind): added
 dotted form as an option for edebug.

Edebug will now work for:

(defun foo (z)
  (destructuring-bind (x . y) z (+ x y)))
---
 emacs-lisp/cl-macs.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs-lisp/cl-macs.el b/emacs-lisp/cl-macs.el
index 60fdc09..a84e677 100644
--- a/emacs-lisp/cl-macs.el
+++ b/emacs-lisp/cl-macs.el
@@ -565,7 +565,7 @@ its argument list allows full Common Lisp conventions."
 (defmacro cl-destructuring-bind (args expr &rest body)
   "Bind the variables in ARGS to the result of EXPR and execute BODY."
   (declare (indent 2)
-           (debug (&define cl-macro-list def-form cl-declarations def-body)))
+           (debug (&define [&or cl-macro-list (sexp . sexp)] def-form cl-declarations def-body)))
   (let* ((cl--bind-lets nil) (cl--bind-forms nil) (cl--bind-inits nil)
 	 (cl--bind-defs nil) (cl--bind-block 'cl-none) (cl--bind-enquote nil))
     (cl--do-arglist (or args '(&aux)) expr)
-- 
1.8.4


[-- Attachment #3: Type: text/plain, Size: 15 bytes --]


regards,
Oleh

             reply	other threads:[~2013-10-11 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 10:39 Oleh [this message]
2013-10-12 19:12 ` bug#15587: [PATCH] Edebug `destructuring-bind' dotted spec Stefan Monnier
2013-10-12 23:28 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjqg9jme.fsf@gmail.com \
    --to=oleh.krehel@gmail.com \
    --cc=15587@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.