all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: 16144@debbugs.gnu.org
Subject: bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.
Date: Sat, 14 Dec 2013 23:18:27 +0900	[thread overview]
Message-ID: <87zjo3cy8c.fsf@dhcp-193-97.nrt.redhat.com> (raw)

I changed bookmark-browse's behavior. This problem gets more serious, if
many many windows are opend...

* Reproduce the problem.
 Step1. Open two windows, one is *eww* and the other is not eww.
 Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*, the other is *eww bookmarks*)
 Step3. Select one URL in the bookmarklist(eww-bookmark-browse).
 Step4. Now emacs window is only *eww*. <- #This is the problem.


Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

        * net/eww.el (eww-bookmark-browse): Don't hide windows with
          browsing bookmark list.

---
 lisp/net/eww.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..c4e948b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1179,10 +1179,8 @@ Differences in #targets are ignored."
   (let ((bookmark (get-text-property (line-beginning-position) 'eww-bookmark)))
     (unless bookmark
       (error "No bookmark on the current line"))
-    ;; We wish to leave this window, but if it's the only window here,
-    ;; just let it remain.
-    (ignore-errors
-      (delete-window))
+    (eww-bookmark-quit)
+    (pop-to-buffer "*eww*")
     (eww-browse-url (plist-get bookmark :url))))

 (defun eww-next-bookmark ()
-- 
1.8.3.1





             reply	other threads:[~2013-12-14 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-14 14:18 Kenjiro NAKAYAMA [this message]
2013-12-21 20:45 ` bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list Ted Zlatanov
2013-12-24  7:02 ` Lars Ingebrigtsen
2013-12-24  7:27   ` Lars Ingebrigtsen
2013-12-24 14:48     ` Stefan Monnier
2013-12-24 18:08       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjo3cy8c.fsf@dhcp-193-97.nrt.redhat.com \
    --to=nakayamakenjiro@gmail.com \
    --cc=16144@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.