From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#18096: 24.3.92; async shell command and a busy buffer leads to error Date: Mon, 28 Jul 2014 02:53:00 +0300 Organization: JURTA Message-ID: <87zjfuxstf.fsf@mail.jurta.org> References: <87bnsf6jl9.fsf@geodiff-mac3.ulb.ac.be> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1406505637 13173 80.91.229.3 (28 Jul 2014 00:00:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Jul 2014 00:00:37 +0000 (UTC) Cc: 18096@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 28 02:00:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBYMf-0002DW-Oc for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 02:00:29 +0200 Original-Received: from localhost ([::1]:36997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBYMf-0007mL-Fp for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Jul 2014 20:00:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBYMS-0007gC-TX for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:00:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBYML-0001Uh-DO for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:00:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBYML-0001Ub-Af for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:00:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XBYMI-0005Y7-T6 for bug-gnu-emacs@gnu.org; Sun, 27 Jul 2014 20:00:07 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jul 2014 00:00:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18096 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18096-submit@debbugs.gnu.org id=B18096.140650557421232 (code B ref 18096); Mon, 28 Jul 2014 00:00:06 +0000 Original-Received: (at 18096) by debbugs.gnu.org; 27 Jul 2014 23:59:34 +0000 Original-Received: from localhost ([127.0.0.1]:39718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBYLm-0005WO-22 for submit@debbugs.gnu.org; Sun, 27 Jul 2014 19:59:34 -0400 Original-Received: from alc-vshost7.dreamhost.com ([69.163.216.107]:42433 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBYLj-0005WE-O0 for 18096@debbugs.gnu.org; Sun, 27 Jul 2014 19:59:32 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.222.226]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 5F0F93095A1661; Sun, 27 Jul 2014 16:59:30 -0700 (PDT) In-Reply-To: <87bnsf6jl9.fsf@geodiff-mac3.ulb.ac.be> (Nicolas Richard's message of "Thu, 24 Jul 2014 14:13:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91859 Archived-At: > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -2904,7 +2904,8 @@ the use of a shell (with its need to quote arguments)." > (error "Shell command in progress"))) > ((eq async-shell-command-buffer 'confirm-new-buffer) > ;; If will create a new buffer, query first. > - (if (yes-or-no-p "A command is running in the default buffer. Use a new buffer? ") > + (if (and (stringp output-buffer) > + (yes-or-no-p "A command is running in the default buffer. Use a new buffer? ")) > (setq buffer (generate-new-buffer > (or output-buffer "*Async Shell Command*"))) > (error "Shell command in progress"))) This will ignore the user customization in `async-shell-command-buffer' if the user want it to ask a question whether to create a new buffer. More tolerating would be trying to get a new buffer name even when the given argument is a buffer: === modified file 'lisp/simple.el' --- lisp/simple.el 2014-07-08 08:27:45 +0000 +++ lisp/simple.el 2014-07-27 23:44:20 +0000 @@ -2986,12 +2986,14 @@ (defun shell-command (command &optional ;; If will create a new buffer, query first. (if (yes-or-no-p "A command is running in the default buffer. Use a new buffer? ") (setq buffer (generate-new-buffer - (or output-buffer "*Async Shell Command*"))) + (or (and (bufferp output-buffer) (buffer-name output-buffer)) + output-buffer "*Async Shell Command*"))) (error "Shell command in progress"))) ((eq async-shell-command-buffer 'new-buffer) ;; It will create a new buffer. (setq buffer (generate-new-buffer - (or output-buffer "*Async Shell Command*")))) + (or (and (bufferp output-buffer) (buffer-name output-buffer)) + output-buffer "*Async Shell Command*")))) ((eq async-shell-command-buffer 'confirm-rename-buffer) ;; If will rename the buffer, query first. (if (yes-or-no-p "A command is running in the default buffer. Rename it? ")