From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.bugs Subject: bug#18513: 24.3; message-mode sends unencrypted on error Date: Mon, 29 Sep 2014 20:09:53 +0900 Message-ID: <87zjdid6ny.fsf-ueno@gnu.org> References: <878ulebz1x.fsf@maritornes.cs.unb.ca> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1411989120 31171 80.91.229.3 (29 Sep 2014 11:12:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Sep 2014 11:12:00 +0000 (UTC) Cc: 18513@debbugs.gnu.org To: David Bremner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 29 13:11:53 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYYrw-00009T-Mm for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Sep 2014 13:11:52 +0200 Original-Received: from localhost ([::1]:35782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYrw-0002T1-8B for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Sep 2014 07:11:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYrF-0001jG-2X for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 07:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYYrE-0007Z7-8i for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 07:11:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYrE-0007Yg-6U for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 07:11:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XYYr8-0001bA-AU for bug-gnu-emacs@gnu.org; Mon, 29 Sep 2014 07:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daiki Ueno Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Sep 2014 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18513 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18513-submit@debbugs.gnu.org id=B18513.14119890026045 (code B ref 18513); Mon, 29 Sep 2014 11:11:02 +0000 Original-Received: (at 18513) by debbugs.gnu.org; 29 Sep 2014 11:10:02 +0000 Original-Received: from localhost ([127.0.0.1]:54890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYYq9-0001ZE-4J for submit@debbugs.gnu.org; Mon, 29 Sep 2014 07:10:01 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:45308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XYYq6-0001Z6-IJ for 18513@debbugs.gnu.org; Mon, 29 Sep 2014 07:09:59 -0400 Original-Received: from du-a.org ([2001:e41:db5e:fb14::1]:35406 helo=debian) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1XYYq5-0005NA-96; Mon, 29 Sep 2014 07:09:57 -0400 In-Reply-To: <878ulebz1x.fsf@maritornes.cs.unb.ca> (David Bremner's message of "Sat, 20 Sep 2014 08:12:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93864 Archived-At: --=-=-= David Bremner writes: > 1) Start emacs with emacs -Q > 2) start sending a message with M-x message-mail > 3) add "sign" tag with C-c C-m C-s > 3) manually replace "sign with "sigencrypt", simulating failed attempt to > manually change mode > 4) add some text to the message, set a destination address and > subject > 5) send using C-c C-c > > The message is sent unencrypted, without any feedback to the user. It > seems that the correct response would be to refuse to send a message > with malformed mml tags. I've installed the following simple fix in the trunk. Does it work for you? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=mml.el.diff === modified file 'lisp/gnus/ChangeLog' --- lisp/gnus/ChangeLog 2014-09-11 19:44:25 +0000 +++ lisp/gnus/ChangeLog 2014-09-29 11:02:32 +0000 @@ -1,3 +1,8 @@ +2014-09-29 Daiki Ueno + + * mml.el (mml-parse-1): Error out if unknown mode is specified in + <#secure> tag (bug#18513). + 2014-09-11 Paul Eggert * gnus-cloud.el (gnus-cloud-parse-version-1): Fix misspelling === modified file 'lisp/gnus/mml.el' --- lisp/gnus/mml.el 2014-03-24 01:56:03 +0000 +++ lisp/gnus/mml.el 2014-09-29 11:00:11 +0000 @@ -257,7 +257,9 @@ ((string= mode "encrypt") (setq tags (list "encrypt" method))) ((string= mode "signencrypt") - (setq tags (list "sign" method "encrypt" method)))) + (setq tags (list "sign" method "encrypt" method))) + (t + (error "Unknown secure mode %s" mode))) (eval `(mml-insert-tag ,secure-mode ,@tags ,(if keyfile "keyfile") --=-=-=--