all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Pål Grønås Drange" <paal.drange@gmail.com>, 20070@debbugs.gnu.org
Subject: bug#20070: 24.3; have commands such as downcase-region act on a rectangle region
Date: Tue, 17 Mar 2015 21:38:06 +0200	[thread overview]
Message-ID: <87zj7b5s9t.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwvsid4iokg.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Mon, 16 Mar 2015 18:08:28 -0400")

>> A list of pairs would be much cleaner, indeed.  The problem is that
>> there are 2 arguments already in region-handling commands: BEG and END.
>> Using one of them for a list of pairs, and leaving another unused
>> is not a nice thing to do.
>
> I think this "lack of niceness" is not strong enough to override the
> advantage of using a list of pairs.

I still have doubts about the API, but anyway here is the implementation
that (ab)uses the first arg BEG:

diff --git a/src/casefiddle.c b/src/casefiddle.c
index 8755353..b77a0e6 100644
--- a/src/casefiddle.c
+++ b/src/casefiddle.c
@@ -306,14 +306,25 @@
   return Qnil;
 }
 
-DEFUN ("downcase-region", Fdowncase_region, Sdowncase_region, 2, 2, "r",
+DEFUN ("downcase-region", Fdowncase_region, Sdowncase_region, 2, 2,
+       "(list (funcall region-extract-function 'positions) nil)",
        doc: /* Convert the region to lower case.  In programs, wants two arguments.
 These arguments specify the starting and ending character numbers of
 the region to operate on.  When used as a command, the text between
 point and the mark is operated on.  */)
   (Lisp_Object beg, Lisp_Object end)
 {
-  casify_region (CASE_DOWN, beg, end);
+  if (CONSP (beg))
+    {
+      while (CONSP (beg))
+	{
+	  casify_region (CASE_DOWN, XCAR (XCAR (beg)), XCDR (XCAR (beg)));
+	  beg = XCDR (beg);
+	}
+    }
+  else
+    casify_region (CASE_DOWN, beg, end);
+
   return Qnil;
 }
 





  reply	other threads:[~2015-03-17 19:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  1:06 bug#20070: 24.3; have commands such as downcase-region act on a rectangle region Pål Grønås Drange
2015-03-11 20:28 ` Stefan Monnier
2015-03-12 19:23   ` Juri Linkov
2015-03-14 16:31     ` Stefan Monnier
2015-03-15 20:34       ` Juri Linkov
2015-03-15 20:41         ` Eli Zaretskii
2015-03-16 11:49           ` Nicolas Richard
2015-03-16 13:14           ` Stefan Monnier
2015-03-16 20:55           ` Juri Linkov
2015-03-16 22:07             ` Stefan Monnier
2015-03-16 13:19         ` Stefan Monnier
2015-03-16 20:58           ` Juri Linkov
2015-03-16 22:08             ` Stefan Monnier
2015-03-17 19:38               ` Juri Linkov [this message]
2015-03-25  0:37                 ` Stefan Monnier
2015-03-25 21:42                   ` Juri Linkov
2015-03-17  7:10             ` Eli Zaretskii
2015-06-30 20:44   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zj7b5s9t.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=20070@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=paal.drange@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.