Bookmark+ stopped working

Bookmark+ stopped working

[Marcin Borkowski]

Hi all,

I upgraded Bookmark+ from the git repo
(git@github.com:emacsmirror/bookmark-plus.git - IIUC, this is a mirror
of the EmacsWiki code, right?)  Now evaluating (require 'bookmark+)
yields this

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (void-function bmkp-replace-regexp-in-string)
  (bmkp-replace-regexp-in-string "\\s-+" "-" type)
  (let* ((type-- (bmkp-replace-regexp-in-string "\\s-+" "-" type)) (command (intern (format "bmkp-bmenu-show-only-%s-bookmarks" type--)))) (list (quote progn) (list (quote defun) command nil doc-string (quote (interactive)) (quote (bmkp-bmenu-barf-if-not-in-menu-list)) (list (quote let) (quote ((orig-filter-fn bmkp-bmenu-filter-function) (orig-title bmkp-bmenu-title) (orig-latest-alist bmkp-latest-bookmark-alist))) (cons (quote condition-case) (cons (quote err) (cons (list ... ... ... ...) (quote ...))))))))
  (lambda (type doc-string filter-function) "Define a command to show only bookmarks of TYPE in *Bookmark List*.\nTYPE is a short string or symbol describing the type of bookmarks.\n\nThe new command is named `bmkp-bmenu-show-only-TYPED-bookmarks', where\nTYPED is TYPE, but with any spaces replaced by hyphens (`-').\nExample: `bmkp-bmenu-show-only-tagged-bookmarks', for TYPE `tagged'.\n\nDOC-STRING is the doc string of the new command.\n\nThe command shows only the bookmarks allowed by FILTER-FUNCTION.\n\nIn case of error, variables `bmkp-bmenu-filter-function',\n`bmkp-bmenu-title', and `bmkp-latest-bookmark-alist' are reset to\ntheir values before the command was invoked." (if (stringp type) nil (setq type (symbol-name type))) (let* ((type-- (bmkp-replace-regexp-in-string "\\s-+" "-" type)) (command (intern (format "bmkp-bmenu-show-only-%s-bookmarks" type--)))) (list (quote progn) (list (quote defun) command nil doc-string (quote (interactive)) (quote (bmkp-bmenu-barf-if-not-in-menu-list)) (list (quote let) (quote ((orig-filter-fn bmkp-bmenu-filter-function) (orig-title bmkp-bmenu-title) (orig-latest-alist bmkp-latest-bookmark-alist))) (cons (quote condition-case) (cons (quote err) (cons ... ...))))))))(lighted "Display (only) the highlighted bookmarks." bmkp-lighted-alist-only)
  (bmkp-define-show-only-command lighted "Display (only) the highlighted bookmarks." bmkp-lighted-alist-only)
  eval-buffer(#<buffer  *load*-39046> nil "/home/marcin/ludzie-works/emacs/bookmark-plus/bookmark+-lit.el" nil t)  ; Reading at buffer position 17856
  load-with-code-conversion("/home/marcin/ludzie-works/emacs/bookmark-plus/bookmark+-lit.el" "/home/marcin/ludzie-works/emacs/bookmark-plus/bookmark+-lit.el" t t)
  require(bookmark+-lit nil t)
  eval-buffer(#<buffer  *load*> nil "/home/marcin/ludzie-works/emacs/bookmark-plus/bookmark+.el" nil t)  ; Reading at buffer position 7207
  load-with-code-conversion("/home/marcin/ludzie-works/emacs/bookmark-plus/bookmark+.el" "/home/marcin/ludzie-works/emacs/bookmark-plus/bookmark+.el" nil t)
  require(bookmark+)
  eval((require (quote bookmark+)) nil)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)
--8<---------------cut here---------------end--------------->8---

I'm on GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 3.10.8).

What's wrong?

Best,

-- 
Marcin Borkowski               This email was proudly sent
http://mbork.pl                from my Emacs.

RE: Bookmark+ stopped working

[Drew Adams]

> I upgraded Bookmark+ from the git repo
> Now evaluating (require 'bookmark+) yields this
> 
> Debugger entered--Lisp error: (void-function bmkp-replace-regexp-in-string)
>   (bmkp-replace-regexp-in-string "\\s-+" "-" type)
>   (let* ((type-- (bmkp-replace-regexp-in-string "\\s-+" "-" type))
> (command (intern (format "bmkp-bmenu-show-only-%s-bookmarks" type--))))

Should be OK now.  Please download the latest bookmark+-lit.el from
Emacs Wiki, or wait up to a day for it to be mirrored on MELPA.
http://www.emacswiki.org/emacs/download/bookmark%2b-lit.el

Or just load bookmark+-mac.el and then byte-compile bookmark+-lit.el.
(There was a missing require for the macros file in bookmark+-lit.el.)

Thx.

Re: Bookmark+ stopped working

[Marcin Borkowski]

On 2015-04-03, at 00:04, Drew Adams <drew.adams@oracle.com> wrote:

>> I upgraded Bookmark+ from the git repo
>> Now evaluating (require 'bookmark+) yields this
>> 
>> Debugger entered--Lisp error: (void-function bmkp-replace-regexp-in-string)
>>   (bmkp-replace-regexp-in-string "\\s-+" "-" type)
>>   (let* ((type-- (bmkp-replace-regexp-in-string "\\s-+" "-" type))
>> (command (intern (format "bmkp-bmenu-show-only-%s-bookmarks" type--))))
>
> Should be OK now.  Please download the latest bookmark+-lit.el from
> Emacs Wiki, or wait up to a day for it to be mirrored on MELPA.
> http://www.emacswiki.org/emacs/download/bookmark%2b-lit.el
>
> Or just load bookmark+-mac.el and then byte-compile bookmark+-lit.el.
> (There was a missing require for the macros file in bookmark+-lit.el.)

Thanks a lot, Drew!  I'll wait, I'm not in a hurry.  Meanwhile, I'm
using vanilla Emacs bookmarks, which has the added benefit that I will
know better what is standard and what comes from bookmark+ (and since
I'll write a blog post about Emacs bookmarks soon, I'd like to know
that).

> Thx.

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

RE: Bookmark+ stopped working

[Drew Adams]

> Thanks a lot, Drew!  I'll wait, I'm not in a hurry.  Meanwhile, I'm
> using vanilla Emacs bookmarks, which has the added benefit that I will
> know better what is standard and what comes from bookmark+ (and since
> I'll write a blog post about Emacs bookmarks soon, I'd like to know
> that).

Be aware that you can use vanilla bookmarks with Bookmark+, but
Bookmark+ provides additional bookmark types etc., which vanilla
Emacs might choke on.  (Whatever you do, back up your bookmark file
occasionally.)

RE: Bookmark+ stopped working

[Drew Adams]

> Should be OK now.  Please download the latest bookmark+-lit.el from
> Emacs Wiki, or wait up to a day for it to be mirrored on MELPA.
> http://www.emacswiki.org/emacs/download/bookmark%2b-lit.el
> Or just load bookmark+-mac.el and then byte-compile bookmark+-lit.el.
> (There was a missing require for the macros file in bookmark+-lit.el.)

Nope; that was not sufficient.  Please update Bookmark+ using the files
I uploaded today.  In particular, there is a change to the macros file,
`bookmark+-mac.el', so this notice applies, if you byte-compile:

 ;; WHENEVER you update Bookmark+ (i.e., download new versions of
 ;; Bookmark+ source files), I recommend that you do the following:
 ;;
 ;; 1. Delete ALL existing BYTE-COMPILED Bookmark+ files
 ;;    (bookmark+*.elc).
 ;; 2. Load Bookmark+ (`load-library' or `require').
 ;; 3. Byte-compile the source files.
 ;;
 ;; In particular, ALWAYS LOAD `bookmark+-mac.el' (not
 ;; `bookmark+-mac.elc') BEFORE YOU BYTE-COMPILE new versions of
 ;; the files, in case there have been any changes to Lisp macros
 ;; (in `bookmark+-mac.el').
 ;;
 ;; (This is standard procedure for Lisp: code that depends on
 ;; macros needs to be byte-compiled anew after loading the
 ;; updated macros.)