From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleh Krehel Newsgroups: gmane.emacs.devel Subject: Re: master 1be349c 1/2: * lisp/emacs-lisp/package.el: Define custom faces Date: Mon, 07 Sep 2015 11:48:03 +0200 Message-ID: <87zj0y4l2k.fsf@gmail.com> References: <20150806102825.25477.3457@vcs.savannah.gnu.org> <8737yspmmp.fsf@gnu.org> <87vbboo6mb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1441619278 8588 80.91.229.3 (7 Sep 2015 09:47:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Sep 2015 09:47:58 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 07 11:47:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZYt1k-0008La-Dj for ged-emacs-devel@m.gmane.org; Mon, 07 Sep 2015 11:47:52 +0200 Original-Received: from localhost ([::1]:55168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYt1k-0005TN-Em for ged-emacs-devel@m.gmane.org; Mon, 07 Sep 2015 05:47:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYt1g-0005SO-Q0 for emacs-devel@gnu.org; Mon, 07 Sep 2015 05:47:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYt1c-0004AD-HH for emacs-devel@gnu.org; Mon, 07 Sep 2015 05:47:48 -0400 Original-Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:35566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYt1c-0004A5-Aj for emacs-devel@gnu.org; Mon, 07 Sep 2015 05:47:44 -0400 Original-Received: by wicge5 with SMTP id ge5so77324374wic.0 for ; Mon, 07 Sep 2015 02:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=ArqwfP+fbvlNrqze5tcK2YozEQX0lGns1uJcnQ/lFaw=; b=Bn5WENWMGNCvOndiv88IVUBmQFd5yVFsvXWXNuUz3dUoIIjyqBTLnpkX929Ca3kMAa HUCSH4nliDjo8OfDjobj92irWJAshKvPqeN81LqihGLrwAisPIZLQ0wqgEplMFxi+7DA i7yCS/IfITCuTzUeK1+iHiUeOQ1Ic6mnKSyS3WigZYjpos0GPh1ojxJEdYSok2MflbST 1Jc6kLsPY14fRrkFqJ4MwBkE+Gg4OlD6XyJa2aGjsGZ1qcMzVSclHiLCsj0+xn+s+rI8 i5M4LbbCobD0+93UYuEKQlmvvp7uUBAXCfQK8GHQLkfzC+n2vxCo9126yNoRNJ2YmnA+ 3tKA== X-Received: by 10.194.77.104 with SMTP id r8mr21382524wjw.102.1441619263089; Mon, 07 Sep 2015 02:47:43 -0700 (PDT) Original-Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by smtp.gmail.com with ESMTPSA id cx1sm14344399wib.0.2015.09.07.02.47.42 for (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Mon, 07 Sep 2015 02:47:42 -0700 (PDT) In-Reply-To: <87vbboo6mb.fsf@gnu.org> ("Johan \=\?utf-8\?Q\?Bockg\=C3\=A5rd\=22's\?\= message of "Sun, 06 Sep 2015 00:15:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189666 Archived-At: Johan Bockg=C3=A5rd writes: > Artur Malabarba writes: > >>> The convention is to not end face names with "-face". >> >> Cool. I prefer to not end the names with `-face', but I was just >> following the lead of the font-lock faces. > > The font-lock face are different for historical reasons. > >> For reference, is this convention stated anywhere? I couldn't find it >> in (info "(elisp) Defining Faces"). > > It says right there: > > -- Macro: defface face spec doc [keyword value]=E2=80=A6 > This macro declares FACE as a named face whose default face spec = is > given by SPEC. You should not quote the symbol FACE, and it shou= ld > not end in =E2=80=98-face=E2=80=99 (that would be redundant). Is it actually a good idea not end with "-face"? I do it for all my packages. And the reason is a very good one: I get completion (completion-at-point, apropos, git-grep, CEDET tags, whatever) for faces with "package-prefix.*-face". It's useful to distinguish the face symbols from the variable symbols. Oleh