Re: master 1be349c 1/2: * lisp/emacs-lisp/package.el: Define custom faces

[Oleh Krehel <ohwoeowho@gmail.com>]

Johan Bockgård <bojohan@gnu.org> writes:

> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
>>> The convention is to not end face names with "-face".
>>
>> Cool. I prefer to not end the names with `-face', but I was just
>> following the lead of the font-lock faces.
>
> The font-lock face are different for historical reasons.
>
>> For reference, is this convention stated anywhere? I couldn't find it
>> in (info "(elisp) Defining Faces").
>
> It says right there:
>
>     -- Macro: defface face spec doc [keyword value]…
>         This macro declares FACE as a named face whose default face spec is
>         given by SPEC.  You should not quote the symbol FACE, and it should
>         not end in ‘-face’ (that would be redundant).

Is it actually a good idea not end with "-face"? I do it for all my
packages. And the reason is a very good one: I get completion
(completion-at-point, apropos, git-grep, CEDET tags, whatever) for faces
with "package-prefix.*-face". It's useful to distinguish the face
symbols from the variable symbols.

    Oleh