From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#21729: doc-view messed up by early auto-revert Date: Fri, 23 Oct 2015 12:08:26 +0200 Message-ID: <87ziz9vqw5.fsf@gnu.org> References: <874mhjtoc2.fsf@gnu.org> <87vb9zx7j2.fsf@gnu.org> <87fv12szdz.fsf@members.fsf.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445594963 18254 80.91.229.3 (23 Oct 2015 10:09:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Oct 2015 10:09:23 +0000 (UTC) Cc: 21729@debbugs.gnu.org, Stefan Monnier To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 23 12:09:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZpZHZ-0005tf-QU for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2015 12:09:09 +0200 Original-Received: from localhost ([::1]:37422 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpZHZ-00009t-C6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Oct 2015 06:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpZHW-00009m-5Y for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 06:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpZHS-0000GH-T5 for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 06:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpZHS-0000GD-Pv for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 06:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZpZHS-0003TG-Ef for bug-gnu-emacs@gnu.org; Fri, 23 Oct 2015 06:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Oct 2015 10:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21729-submit@debbugs.gnu.org id=B21729.144559491413307 (code B ref 21729); Fri, 23 Oct 2015 10:09:02 +0000 Original-Received: (at 21729) by debbugs.gnu.org; 23 Oct 2015 10:08:34 +0000 Original-Received: from localhost ([127.0.0.1]:33839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpZH0-0003SZ-0C for submit@debbugs.gnu.org; Fri, 23 Oct 2015 06:08:34 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33562) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpZGy-0003SQ-Ad for 21729@debbugs.gnu.org; Fri, 23 Oct 2015 06:08:32 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 693022035B for <21729@debbugs.gnu.org>; Fri, 23 Oct 2015 06:08:30 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 23 Oct 2015 06:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=PqOyg2z4m8JUQPQrD42lD+QiyLs=; b=dUwNq GOBNo6c+Jft4q9ugaiYZAXocQXYF9/L2zU7BnH8IEJRwh7RRScf9WgmtxXleKjh0 alhiN6uT1Ikowzxq2y6t6y2H8P/8So5vHmyLZQl23FpKmtB7bvGYRBB2Hqyp2dG5 PNrLZfM+iQlZOIDhLPn9ms/NrOOe+NyIvBFYBo= X-Sasl-enc: 6Nwn2OoDmFojtjjowKrBze1/Q/D3iLAmJMvUicf82gqt 1445594909 Original-Received: from thinkpad-t440p (unknown [2.161.212.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 2D4EA6800EA; Fri, 23 Oct 2015 06:08:28 -0400 (EDT) In-Reply-To: <87fv12szdz.fsf@members.fsf.org> (Nicolas Richard's message of "Fri, 23 Oct 2015 11:33:12 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107908 Archived-At: Nicolas Richard writes: > Tassilo Horn writes: >> I think in doc-view-mode it's obvious enough when a file is being >> reverted, so maybe we should set auto-revert-verbose to nil >> buffer-locally? > > Sometimes emacs does weird things, and I think it's nice if it > explains what it does, even if it should be obvious. Morever the > message is not only useful while the file is being reverted, but also > after the fact. e.g. if I have foo.pdf open, and that file is > controlled by owncloud and gets updated by the cloud, I like to find > this information in *Messages*. Yes, I see. But then we could still set `auto-revert-verbose' to nil buffer-locally and issue that message in `doc-view-revert-buffer'. The problem with the message from autorevert.el is that it'll be displayed even though doc-view decides that it cannot auto-revert right now because the file is corrupted/not ready yet. Alternatively, we could of course enhance autorevert.el, e.g., by introducing some buffer-local variable `auto-revert-predicate' which is run by auto-revert in order to test if the current buffer can be reverted right now. That could then be used by doc-view, and I guess there are other modes which could make use of such a feature, too. Stefan, do you think that would be a good idea? Bye, Tassilo