From: Tassilo Horn <tsdh@gnu.org>
To: Nicolas Richard <youngfrog@members.fsf.org>
Cc: 21729@debbugs.gnu.org, Stefan Monnier <monnier@IRO.UMontreal.CA>
Subject: bug#21729: doc-view messed up by early auto-revert
Date: Fri, 23 Oct 2015 12:08:26 +0200 [thread overview]
Message-ID: <87ziz9vqw5.fsf@gnu.org> (raw)
In-Reply-To: <87fv12szdz.fsf@members.fsf.org> (Nicolas Richard's message of "Fri, 23 Oct 2015 11:33:12 +0200")
Nicolas Richard <youngfrog@members.fsf.org> writes:
> Tassilo Horn <tsdh@gnu.org> writes:
>> I think in doc-view-mode it's obvious enough when a file is being
>> reverted, so maybe we should set auto-revert-verbose to nil
>> buffer-locally?
>
> Sometimes emacs does weird things, and I think it's nice if it
> explains what it does, even if it should be obvious. Morever the
> message is not only useful while the file is being reverted, but also
> after the fact. e.g. if I have foo.pdf open, and that file is
> controlled by owncloud and gets updated by the cloud, I like to find
> this information in *Messages*.
Yes, I see. But then we could still set `auto-revert-verbose' to nil
buffer-locally and issue that message in `doc-view-revert-buffer'. The
problem with the message from autorevert.el is that it'll be displayed
even though doc-view decides that it cannot auto-revert right now
because the file is corrupted/not ready yet.
Alternatively, we could of course enhance autorevert.el, e.g., by
introducing some buffer-local variable `auto-revert-predicate' which is
run by auto-revert in order to test if the current buffer can be
reverted right now. That could then be used by doc-view, and I guess
there are other modes which could make use of such a feature, too.
Stefan, do you think that would be a good idea?
Bye,
Tassilo
next prev parent reply other threads:[~2015-10-23 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 18:05 bug#21729: doc-view messed up by early auto-revert Stefan Monnier
2015-10-22 6:22 ` Tassilo Horn
2015-10-22 13:10 ` Stefan Monnier
2015-10-22 15:11 ` Tassilo Horn
2015-10-23 9:33 ` Nicolas Richard
2015-10-23 10:08 ` Tassilo Horn [this message]
2019-09-29 13:03 ` Lars Ingebrigtsen
2019-10-03 9:21 ` Tassilo Horn
2022-02-03 21:01 ` Lars Ingebrigtsen
2019-10-03 13:31 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziz9vqw5.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=21729@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=youngfrog@members.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.