From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Fixing compilation and byte-compilation warnings before 25.1 Date: Sun, 15 Nov 2015 13:41:12 +0100 Message-ID: <87ziyfsadz.fsf@web.de> References: <5645F670.9040601@online.de> <56460E2B.10603@cs.ucla.edu> <87io54c0es.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447657874 23651 80.91.229.3 (16 Nov 2015 07:11:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Nov 2015 07:11:14 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 16 08:11:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZyDwP-00018R-RP for ged-emacs-devel@m.gmane.org; Mon, 16 Nov 2015 08:11:05 +0100 Original-Received: from localhost ([::1]:46605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyDwP-0000jm-Db for ged-emacs-devel@m.gmane.org; Mon, 16 Nov 2015 02:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxwca-0008MZ-N4 for emacs-devel@gnu.org; Sun, 15 Nov 2015 07:41:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxwcV-0002wc-Nk for emacs-devel@gnu.org; Sun, 15 Nov 2015 07:41:28 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:33631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxwcV-0002wY-H7 for emacs-devel@gnu.org; Sun, 15 Nov 2015 07:41:23 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZxwcT-00023g-AX for emacs-devel@gnu.org; Sun, 15 Nov 2015 13:41:21 +0100 Original-Received: from ip-90-186-0-44.web.vodafone.de ([90.186.0.44]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Nov 2015 13:41:21 +0100 Original-Received: from michael_heerdegen by ip-90-186-0-44.web.vodafone.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 15 Nov 2015 13:41:21 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: ip-90-186-0-44.web.vodafone.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:rzSvhEL5BXN39kORUrkyIZf+5aQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194528 Archived-At: daniel sutton writes: > Ah thank you. Someone responded and made a new thread and were super > helpful as well. It seems like this warning needs to go to new > consumers but not in the core. Would it be appropriate for the declare > statement to somehow tell the compiler that we are in the core and > therefore to suppress warnings of this type? I don't think that suppressing blindly all warnings of any particular type is a good idea. Some of them might indicate problems. > One suggestion was to add the recursive call into a (with-no-warnings > ...) call, but this could get tedious and invasive. Why not just leave this one particular warning? It reminds us we still have something to change there in the future. Michael.