From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthew Leach Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v5] Add systemd socket launching support Date: Tue, 26 Apr 2016 10:17:36 +0100 Message-ID: <87zisg91an.fsf@mattleach.net> References: <871t6do8w1.fsf@mattleach.net> <87inzkrs8c.fsf@mattleach.net> <5713224F.9040602@cs.ucla.edu> <87h9f0ealq.fsf@mattleach.net> <57147449.4060307@cs.ucla.edu> <874maun0el.fsf@mattleach.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461662285 13222 80.91.229.3 (26 Apr 2016 09:18:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 09:18:05 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 11:17:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auz81-0000s4-6J for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 11:17:57 +0200 Original-Received: from localhost ([::1]:37022 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auz80-0006rt-AB for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 05:17:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auz7k-0006oW-E0 for emacs-devel@gnu.org; Tue, 26 Apr 2016 05:17:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auz7g-0001Q8-CU for emacs-devel@gnu.org; Tue, 26 Apr 2016 05:17:40 -0400 Original-Received: from mx0.mattleach.net ([176.58.118.143]:46790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auz7g-0001NX-7F for emacs-devel@gnu.org; Tue, 26 Apr 2016 05:17:36 -0400 Original-Received: by mx0.mattleach.net (Postfix, from userid 99) id AD2226222F; Tue, 26 Apr 2016 10:17:34 +0100 (BST) Original-Received: from spline.mattleach.net (unknown [213.86.103.11]) by mx0.mattleach.net (Postfix) with ESMTPSA id 4568462228; Tue, 26 Apr 2016 10:17:31 +0100 (BST) In-Reply-To: <874maun0el.fsf@mattleach.net> (Matthew Leach's message of "Thu, 21 Apr 2016 21:59:30 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 176.58.118.143 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203326 Archived-At: Hi Paul, Matthew Leach writes: > Paul Eggert writes: [...] >> @@ -7775,7 +7772,7 @@ init_process_emacs (void) >> FD_ZERO (&non_keyboard_wait_mask); >> FD_ZERO (&non_process_wait_mask); >> FD_ZERO (&write_mask); >> - max_process_desc = max_input_desc = -1; >> + max_process_desc = max_input_desc = external_sock_fd = -1; > > Setting `external_sock_fd' here doesn't work as 'init_process_emacs' is > called later in 'main' than 'set_external_socket_descriptor' is; any > descriptor that is passed through from systemd would be overwritten with > -1. Should I send in a patch to fix this or are you OK doing it? Thanks, -- Matt