From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list' Date: Fri, 29 Apr 2016 22:07:34 +0200 Message-ID: <87ziscuqk9.fsf@gnus.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461960529 20822 80.91.229.3 (29 Apr 2016 20:08:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Apr 2016 20:08:49 +0000 (UTC) Cc: 17582@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 29 22:08:33 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awEiG-00028E-1T for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 22:08:32 +0200 Original-Received: from localhost ([::1]:56102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awEiC-0002Vd-3p for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Apr 2016 16:08:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awEi1-0002Fk-Mf for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 16:08:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awEhp-0000ck-Ph for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 16:08:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awEhp-0000aL-Mu for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 16:08:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awEhm-0001Y3-6U for bug-gnu-emacs@gnu.org; Fri, 29 Apr 2016 16:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Apr 2016 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17582 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17582-submit@debbugs.gnu.org id=B17582.14619604595908 (code B ref 17582); Fri, 29 Apr 2016 20:08:02 +0000 Original-Received: (at 17582) by debbugs.gnu.org; 29 Apr 2016 20:07:39 +0000 Original-Received: from localhost ([127.0.0.1]:55882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awEhP-0001XD-80 for submit@debbugs.gnu.org; Fri, 29 Apr 2016 16:07:39 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:50173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awEhN-0001X6-Kn for 17582@debbugs.gnu.org; Fri, 29 Apr 2016 16:07:38 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awEhK-0002JD-To; Fri, 29 Apr 2016 22:07:36 +0200 In-Reply-To: (Drew Adams's message of "Sat, 24 May 2014 14:46:36 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117255 Archived-At: Drew Adams writes: > I took only a cursory look at the code, after finding out that eldoc's > idle timer was still getting called after I had turned off `eldoc-mode'. > I discovered this because I had `debug-on-entry' for `split-string'. > > Seems like turning off `eldoc-mode' should not only remove > `eldoc-schedule-timer' from `post-command-hook' but should also turn off > that timer, so it does not keep turning eldoc back on. It seems that > nothing ever removes `eldoc-timer' from `timer-idle-list' or deletes the > timer. I've now made switching eldoc mode off cancel the timer. If eldoc mode is running in other buffers, the post-command-hook will ensure that it's started again whenever you do something, so I think that should be ok... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no