bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list'

bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list'

[Drew Adams]

I took only a cursory look at the code, after finding out that eldoc's
idle timer was still getting called after I had turned off `eldoc-mode'.
I discovered this because I had `debug-on-entry' for `split-string'.

Seems like turning off `eldoc-mode' should not only remove
`eldoc-schedule-timer' from `post-command-hook' but should also turn off
that timer, so it does not keep turning eldoc back on.  It seems that
nothing ever removes `eldoc-timer' from `timer-idle-list' or deletes the
timer.

It's possible I'm missing something, but this seems wrong.

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-05-17 on ODIEONE
Bzr revision: 117119 eggert@cs.ucla.edu-20140517081131-ugu7ociaoec2xk7y
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list'

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> I took only a cursory look at the code, after finding out that eldoc's
> idle timer was still getting called after I had turned off `eldoc-mode'.
> I discovered this because I had `debug-on-entry' for `split-string'.
>
> Seems like turning off `eldoc-mode' should not only remove
> `eldoc-schedule-timer' from `post-command-hook' but should also turn off
> that timer, so it does not keep turning eldoc back on.  It seems that
> nothing ever removes `eldoc-timer' from `timer-idle-list' or deletes the
> timer.

I've now made switching eldoc mode off cancel the timer.

If eldoc mode is running in other buffers, the post-command-hook will
ensure that it's started again whenever you do something, so I think
that should be ok...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no