From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 17582@debbugs.gnu.org
Subject: bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list'
Date: Fri, 29 Apr 2016 22:07:34 +0200 [thread overview]
Message-ID: <87ziscuqk9.fsf@gnus.org> (raw)
In-Reply-To: <cf35e1df-4825-4c5e-9905-78e40f755f7c@default> (Drew Adams's message of "Sat, 24 May 2014 14:46:36 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> I took only a cursory look at the code, after finding out that eldoc's
> idle timer was still getting called after I had turned off `eldoc-mode'.
> I discovered this because I had `debug-on-entry' for `split-string'.
>
> Seems like turning off `eldoc-mode' should not only remove
> `eldoc-schedule-timer' from `post-command-hook' but should also turn off
> that timer, so it does not keep turning eldoc back on. It seems that
> nothing ever removes `eldoc-timer' from `timer-idle-list' or deletes the
> timer.
I've now made switching eldoc mode off cancel the timer.
If eldoc mode is running in other buffers, the post-command-hook will
ensure that it's started again whenever you do something, so I think
that should be ok...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2016-04-29 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 21:46 bug#17582: 24.4.50; once `eldoc-mode' has been enabled, its timer remains on `timer-idle-list' Drew Adams
2016-04-29 20:07 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziscuqk9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=17582@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.