From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Markus Triska Newsgroups: gmane.emacs.bugs Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Date: Sat, 02 Jul 2016 22:53:37 +0200 Message-ID: <87zipz223y.fsf@metalevel.at> References: <83h9cavdgj.fsf@gnu.org> <87poqyy2tc.fsf@metalevel.at> <87vb0qqrkz.fsf@russet.org.uk> <87h9c9zx75.fsf@metalevel.at> <834m89vmyv.fsf@gnu.org> <878txlsbdb.fsf@russet.org.uk> <87furtccdv.fsf@metalevel.at> <877fd5q9te.fsf@russet.org.uk> <83bn2gtruk.fsf@gnu.org> <87k2h37pvb.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1467492862 20038 80.91.229.3 (2 Jul 2016 20:54:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jul 2016 20:54:22 +0000 (UTC) Cc: 23871@debbugs.gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 02 22:54:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJRvY-0005wm-SK for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2016 22:54:13 +0200 Original-Received: from localhost ([::1]:40061 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJRvY-0000wA-6V for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2016 16:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJRvS-0000mn-IB for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 16:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJRvO-0001CD-D3 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 16:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJRvO-0001C9-9d for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 16:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJRvO-0001Um-4C for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Markus Triska Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2016 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23871-submit@debbugs.gnu.org id=B23871.14674928205720 (code B ref 23871); Sat, 02 Jul 2016 20:54:02 +0000 Original-Received: (at 23871) by debbugs.gnu.org; 2 Jul 2016 20:53:40 +0000 Original-Received: from localhost ([127.0.0.1]:34887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJRv2-0001UC-0k for submit@debbugs.gnu.org; Sat, 02 Jul 2016 16:53:40 -0400 Original-Received: from metalevel.at ([78.46.218.83]:50732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJRv0-0001U4-84 for 23871@debbugs.gnu.org; Sat, 02 Jul 2016 16:53:38 -0400 Original-Received: by metalevel.at (Postfix, from userid 1000) id 0B1DCA0339; Sat, 2 Jul 2016 22:53:37 +0200 (CEST) In-Reply-To: <87k2h37pvb.fsf@russet.org.uk> (Phillip Lord's message of "Sat, 02 Jul 2016 21:21:28 +0100") User-Agent: Emacs/24.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120307 Archived-At: Hi Phillip, phillip.lord@russet.org.uk (Phillip Lord) writes: > I believe the following patch addresses the issue. This patch causes a regression with the original case I posted in this report (#23871): Without your patch, after undo, point is *either* (1) at the beginning of line 15 OR (2) at a position that is outside the buffer (point 323 of 322). Case (1) is the expected behaviour, and case (2) is the issue I reported and which, just FYI, also still arises with your patch applied. However, your patch also leads to the new problem that even in cases where the point is not outside the buffer, it is unexpectedly placed at the *end* of line 15 instead of at the beginning, where ediprolog-dwim was invoked before the insertion is undone. In this sense, the behaviour is worse than before for #23871 with your patch, because point is never restored to where the interaction started. All the best! Markus