all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: two likely bugs with qualified methods
Date: Fri, 15 Jul 2016 00:11:05 -0700	[thread overview]
Message-ID: <87zipjidfa.fsf@ericabrahamsen.net> (raw)

Not serious ones, but...

See the following:

(cl-defmethod base ((str string))
  "This one's okay"
  (message str))

(cl-defmethod base :extra "ext" ((str string))
	      "This one isn't"
	      (message "extra method")
	      (cl-call-next-method))

The first problem should be evident: alignment doesn't work correctly
for any qualified methods. This is with emacs -Q, built from master.

Additionally, if you try to instrument the second form for edbugging,
the cursor jumps to the first argument in the argument list, and you
get:

edebug-syntax-error: Invalid read syntax: "Expected lambda expression"

That only happens with the :extra qualifier (I assume because it has an
additional positional element before the arg list).

Both of these are pretty much just chrome, but they're fairly important
chrome! I will open a couple of bug reports, if necessary.

Thanks,
Eric




             reply	other threads:[~2016-07-15  7:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  7:11 Eric Abrahamsen [this message]
2016-07-15  8:25 ` two likely bugs with qualified methods Clément Pit--Claudel
2016-07-15 13:31   ` Stefan Monnier
2016-07-15 16:04   ` Eric Abrahamsen
2016-07-15 13:27 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zipjidfa.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.