From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.bugs Subject: bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function Date: Fri, 15 Jul 2016 12:50:02 -0700 Message-ID: <87zipik7f9.fsf@cochranmail.com> References: <871t2vrg1q.fsf@cochranmail.com> <83lh1374ry.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1468630509 30710 80.91.229.3 (16 Jul 2016 00:55:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jul 2016 00:55:09 +0000 (UTC) Cc: 23988@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 16 02:54:57 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bODrK-0007pf-6Q for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jul 2016 02:53:34 +0200 Original-Received: from localhost ([::1]:34733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO98k-0004pF-Jp for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Jul 2016 15:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO98c-0004nl-G4 for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 15:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bO98Y-0008MJ-BI for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 15:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bO98Y-0008MF-8E for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 15:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bO98Y-0008EK-3I for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2016 15:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2016 19:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23988 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23988-submit@debbugs.gnu.org id=B23988.146861222731594 (code B ref 23988); Fri, 15 Jul 2016 19:51:02 +0000 Original-Received: (at 23988) by debbugs.gnu.org; 15 Jul 2016 19:50:27 +0000 Original-Received: from localhost ([127.0.0.1]:53312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO97z-0008DW-DK for submit@debbugs.gnu.org; Fri, 15 Jul 2016 15:50:27 -0400 Original-Received: from mail.workgrouplinux.net ([207.195.177.82]:43979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bO97y-0008DL-7u for 23988@debbugs.gnu.org; Fri, 15 Jul 2016 15:50:26 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=UbYuCIdOLxu1DhPqPu6vjBSoHKk=; b=mv7yk olPBG4h4OfZg8sA20YHA1sS4upR52RzcWREZEudiEwavqzyTCJIvSPa6laTzvJE6 ZKipFhj5gJZvolGdfCZlq9YbhYSRgtMGhp70BNjAv5E3myYoc/rsekECjMOC7zjN es68PtqxwKqrPIgQvVq020BhE2fXtyXn16hEhvtpnRdHrROKwbddAKIBqCIwhscN 7RYi3NGo46Kx5IV7EFaG3qoPvdC0tNZaX0M0cFeweK4yHi8sat47YfU7MPY1pnRl 2SvmGcJ4/jdcw6Mt6eKJz/o/SuqtFbUHQ6OitXzw5z5uHGCPtBXL/Ga5asE4iyq8 z8Wo0USzn+lN6nuUw== Original-Received: (qmail 24634 invoked by uid 0); 15 Jul 2016 19:50:22 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=BGr/1iKOr2j8XTT3MwNqLmr7FOrnArqpbQl9MuzxR3d3AYoSg9g1VStCYP/AatVlxk+P08N1PKUuRmwytUcfhQ==; Original-Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 15 Jul 2016 19:50:22 -0000 In-Reply-To: <83lh1374ry.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Jul 2016 10:13:21 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121128 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > How about adding a comment there that summarizes the discussion in > that bug? Perhaps someone will come up with a clever idea to overcome > the difficulties. That's a good point. I have attached a new patch that summarizes the discussion. Thanks, ~Robert Cochran --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Expand-FIXME-near-definition-of-fboundp.patch Content-Description: Patch that details discussion of the fboundp FIXME >From 60921ce566429711c7366ab6663fa37ee97b9190 Mon Sep 17 00:00:00 2001 From: Robert Cochran Date: Fri, 15 Jul 2016 12:45:56 -0700 Subject: [PATCH] Expand FIXME near definition of fboundp This expansion of the FIXME is so that future developers are aware of the potential problems of aliasing fboundp to symbol-function without taking backwards compatibility into account. * src/data.c (fboundp): Note potential backwards compatibility issues in FIXME. --- src/data.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/data.c b/src/data.c index 71da916..9846006 100644 --- a/src/data.c +++ b/src/data.c @@ -629,7 +629,12 @@ global value outside of any lexical scope. */) return (EQ (valcontents, Qunbound) ? Qnil : Qt); } -/* FIXME: Make it an alias for function-symbol! */ +/* FIXME: It has been previously suggested to make this function an + alias for symbol-function, but upon discussion at Debbug#23957, + there is a risk breaking backward compatiblity, as some users of + fboundp may expect `t' in particular, rather than any true + value. An alias is still welcome so long as the compatibility + issues are addressed. */ DEFUN ("fboundp", Ffboundp, Sfboundp, 1, 1, 0, doc: /* Return t if SYMBOL's function definition is not void. */) (register Lisp_Object symbol) -- 2.7.4 --=-=-=--