From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#24071: [PATCH] Refactor regex character class parsing in [:name:] Date: Thu, 28 Jul 2016 22:31:48 -0700 Message-ID: <87zip1t3gb.fsf@secretsauce.net> References: <1469487245-11126-1-git-send-email-mina86@mina86.com> <83d1m0tq25.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469770351 15663 80.91.229.3 (29 Jul 2016 05:32:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jul 2016 05:32:31 +0000 (UTC) Cc: 24071@debbugs.gnu.org, Michal Nazarewicz To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 29 07:32:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bT0PC-0001YA-UQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 07:32:19 +0200 Original-Received: from localhost ([::1]:57540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0P6-0007ad-HF for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 01:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0P1-0007aX-2Q for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT0Oz-0000Pg-0f for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:32:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT0Ow-0000PT-O7 for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:32:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bT0Ow-0004c7-Eu for bug-gnu-emacs@gnu.org; Fri, 29 Jul 2016 01:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jul 2016 05:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24071-submit@debbugs.gnu.org id=B24071.146977031317720 (code B ref 24071); Fri, 29 Jul 2016 05:32:02 +0000 Original-Received: (at 24071) by debbugs.gnu.org; 29 Jul 2016 05:31:53 +0000 Original-Received: from localhost ([127.0.0.1]:49897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT0Om-0004bk-Oh for submit@debbugs.gnu.org; Fri, 29 Jul 2016 01:31:52 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bT0Ol-0004bb-7D for 24071@debbugs.gnu.org; Fri, 29 Jul 2016 01:31:51 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B60F2203D3; Fri, 29 Jul 2016 01:31:50 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Fri, 29 Jul 2016 01:31:50 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=wGfJp C2mcab8csdEtzLY+rEenH8=; b=KWtjsLg/IQkKZ/ZJGD7Ly2R0/RUYE7xUWPlrl QlIHxfk6ITfhevjPN/cKOcGPDBdGtXajoZe6PLvwSsd7LXosQ8ILZ+0U39yx38Ug sbtZ1Rm8WRnLOR6lu4ZaUG6ANkcnNuxVKLHQIl2Dr5M64geOT2slBO5QzqTuYoek D7h+IU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=wGfJpC2mcab8csdEtzLY+rEenH8=; b=rKs1w 95Q9skx8ijWGmlcOsZQFnYjOaPRL42Y6ZH1fB7VxkeqB+BcL/7pOmWx3Kaii6GZW lT/48KvjB3TEw/SvDdw/+dzHAOef9DAyHoRVBym/PgS3mVTW25ZNa4RhJpzeqek7 FkSD1zhZYM1XYK2yX2Q1hCA/UeBmo5tdNC0HV8= X-Sasl-enc: VKRso9HSkiyCq37ZViPq20DsHM0/pHwlUhWnloHyJ/aQ 1469770310 Original-Received: from shorty.local (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E526CCDC5; Fri, 29 Jul 2016 01:31:50 -0400 (EDT) Original-Received: from dima by shorty.local with local (Exim 4.87) (envelope-from ) id 1bT0Oi-0001fi-SL; Thu, 28 Jul 2016 22:31:48 -0700 User-agent: mu4e 0.9.17; emacs 25.0.95.1 In-reply-to: <83d1m0tq25.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121668 Archived-At: Eli Zaretskii writes: > If we are going to make some serious refactoring in regex.c, I think > we should start with having a test suite for it. The > dima_regex_embedded_modifiers branch, created by Dima Kogan (CC'ed) in > the Emacs repository includes a suite taken from glibc. Dima, could > you perhaps merge the parts of the test suite that can already be used > to the master branch, so that we could use them to verify changes in > regex.c? Hi. I just saw this. Do you still need me to get these merged? That branch is very clean, so just cherry-picking the specific commits should do it.