From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Newsgroups: gmane.emacs.bugs Subject: bug#24620: 26.0.50; In dired: 'dired-do-compress-to' fails when filenames cotains space characters Date: Sun, 30 Oct 2016 09:33:19 +0100 Message-ID: <87zilm1bjk.wl-domenechjosel@gmail.com> References: <87ponfi8ay.wl-j_l_domenech@yahoo.com> <878tt9zy64.wl-domenechjosel@gmail.com> <87funhd7ba.fsf@gmx.de> <87bmy5bpqz.wl-domenechjosel@gmail.com> <87insdpp45.wl-domenechjosel@gmail.com> <87wpgtqt92.fsf@users.sourceforge.net> <87a8dp0x6v.wl-domenechjosel@gmail.com> <87r36zrjr4.fsf@users.sourceforge.net> <8737jfjyzm.wl-domenechjosel@gmail.com> <87k2crqrz1.fsf@users.sourceforge.net> <87insbdmmk.wl-domenechjosel@gmail.com> <87bmy2r4y2.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Trace: blaine.gmane.org 1477816458 25354 195.159.176.226 (30 Oct 2016 08:34:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Oct 2016 08:34:18 +0000 (UTC) User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Cc: 24620@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 30 09:34:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0lZD-0005aE-4c for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Oct 2016 09:34:11 +0100 Original-Received: from localhost ([::1]:57409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0lZF-0004EZ-NK for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Oct 2016 04:34:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0lZ8-0004EJ-9B for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 04:34:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0lZ4-000352-TN for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 04:34:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49802) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c0lZ4-00034w-Qb for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 04:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c0lZ4-0002Lm-GD for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 04:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jos=C3=A9?= L. =?UTF-8?Q?Dom=C3=A9nech?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2016 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24620 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 24620-submit@debbugs.gnu.org id=B24620.14778164098948 (code B ref 24620); Sun, 30 Oct 2016 08:34:02 +0000 Original-Received: (at 24620) by debbugs.gnu.org; 30 Oct 2016 08:33:29 +0000 Original-Received: from localhost ([127.0.0.1]:36968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0lYX-0002KG-F2 for submit@debbugs.gnu.org; Sun, 30 Oct 2016 04:33:29 -0400 Original-Received: from mail-wm0-f67.google.com ([74.125.82.67]:35638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0lYV-0002Jp-S5 for 24620@debbugs.gnu.org; Sun, 30 Oct 2016 04:33:28 -0400 Original-Received: by mail-wm0-f67.google.com with SMTP id 68so7073421wmz.2 for <24620@debbugs.gnu.org>; Sun, 30 Oct 2016 01:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:user-agent:disposition-notification-to:return-receipt-to :mime-version; bh=6/8QiC0te7+h1Ndq1Z7gsiuHLI+0oDW7aYFGy3qWV8w=; b=TrMsjmrCmiR9KD44sF7gsLQPDSlxP8MqzfQ0j73MmOTNLcNFwQOo+UApaZWbYjiPhs s7GUlQiNx7CV2KkgnFaO8qT/NnDwHOfB4W1Le6rOuogkWcXf066Q7ldWpzoGYpjHntMe q5bg45K5tQg9p0Oo6ArlCDMGfncnvOSImapSlyarRfQWQoIW1Q7jWcF+iwqASWQtsXR/ 631sIJhY9tpQyrVGLVbiuPDxSncIainqx9bivvXn8gHLZ5XtClkRqj24RCLJhC1hpVpp RWi1sxxU+LdW6fO2y9mmN5E67BD0SymjybM5L4qNnu0IvEONPpz0ymJJB61mQZMPq8Gt VoMg== X-Gm-Message-State: ABUngvcUk9yM9pFwR5bJCO4c6DqBwMUNDo4djjdqTqiKifiFP2bOeMkrnxwgbulFhn/bsw== X-Received: by 10.194.104.168 with SMTP id gf8mr18141079wjb.31.1477816401966; Sun, 30 Oct 2016 01:33:21 -0700 (PDT) Original-Received: from jose-ThinkPad-Edge-E330.gmail.com (110.red-79-144-230.dynamicip.rima-tde.net. [79.144.230.110]) by smtp.gmail.com with ESMTPSA id o143sm18311437wmd.7.2016.10.30.01.33.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Oct 2016 01:33:21 -0700 (PDT) In-Reply-To: <87bmy2r4y2.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125143 Archived-At: On Sun, 30 Oct 2016 02:39:01 +0100, npostavs@users.sourceforge.net wrote: > > [1 ] > tags 24620 fixed > close 24620 26 > quit > > > I don't worry about delays which are approximately 0 days long :) > > > Okay, now the summary line is a bit too long. I shortened the summary > and pushed your patch to master. > Thank you. > [2 patch ] > From 27443df092bfb4ada559f8fc024e01f174a5bcb0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Dom=C3=A9nech?= > Date: Sat, 29 Oct 2016 21:18:31 -0400 > Subject: [PATCH] Quote file names in dired compression commands > > * lisp/dired-aux.el (dired-do-compress-to): Change the string > used as shell command for compression by quoting the filenames > used for input and output (Bug #24620). > --- > lisp/dired-aux.el | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index d25352e..972b6b1 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -1012,11 +1012,13 @@ dired-do-compress-to > (t > (when (zerop > (dired-shell-command > - (replace-regexp-in-string > - "%o" out-file > - (replace-regexp-in-string > - "%i" (mapconcat #'file-name-nondirectory in-files " ") > - (cdr rule))))) > + (format-spec (cdr rule) > + `((?\o . ,(shell-quote-argument out-file)) > + (?\i . ,(mapconcat > + (lambda (file-desc) > + (shell-quote-argument (file-name-nondirectory > + file-desc))) > + in-files " ")))))) > (message "Compressed %d file(s) to %s" > (length in-files) > (file-name-nondirectory out-file))))))) > -- > 2.9.3 > > [3 ] > > > > Thanks for your contribution. > > P.S. your mails seem to be getting duplicated (or even triplicated for the > last one). Sorry, it is all my fault. I still has to get a configuration for the mailinglist+NNTP+gmane (with wanderlust) where I get comfortable so i don't resend the messages when a error occurs in the sending process. Thanks again.