From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 07 Nov 2016 11:58:07 +0100 Message-ID: <87zilbeev4.fsf@gmx.de> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> <8760nzfunl.fsf@gmx.de> <05d06a0a-e6df-5d54-01bf-7bb9447a2f7e@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478516419 19513 195.159.176.226 (7 Nov 2016 11:00:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 11:00:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Eli Zaretskii , Nikolay Kudryavtsev , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 12:00:11 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3heY-0001vH-Qs for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 11:59:50 +0100 Original-Received: from localhost ([::1]:52964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3heb-0007hv-Sg for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 05:59:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3hd7-0007Bp-D8 for emacs-devel@gnu.org; Mon, 07 Nov 2016 05:58:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3hd3-0007rs-0n for emacs-devel@gnu.org; Mon, 07 Nov 2016 05:58:21 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:64305) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3hcw-0007p8-IF; Mon, 07 Nov 2016 05:58:10 -0500 Original-Received: from detlef.gmx.de ([87.146.53.66]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M5a9E-1d18sS0ms4-00xeGz; Mon, 07 Nov 2016 11:58:08 +0100 In-Reply-To: <05d06a0a-e6df-5d54-01bf-7bb9447a2f7e@yandex.ru> (Dmitry Gutov's message of "Mon, 7 Nov 2016 12:39:06 +0200") X-Provags-ID: V03:K0:nV3xQUssWSVmJOMzPPvH8J4vH1dlYyKYDTY1ujHZrMFb91Qqk9S g1oJvlZ6guR2cS3hEo2Ah09MjXagH5Z4SqmaEoLWeIXHYd+jXaHSqejdCdVGxfitVPk31dS ExVpg5Qosj7dKLakTnsOPDmxQNEAzaWHvWb7ZxseOjovPzCfi/Qsd4P5F8SG33y02XpiMUV /48jUc6eV5jWpc6aK6VWw== X-UI-Out-Filterresults: notjunk:1;V01:K0:aaFaQD70ZTA=:fvFM0sXpnXWgJiPppbwfCR xroxEw3/YHhHgxrGHY64Vq5Wn/em69alE4NxKblUJHPT6TGyEJP7IJxHhWwoKijXyrhBDATzm WHraxxt2X3JWczc30Os8lJSeKrXdjE7SacRMwkD0TTHTfm6LPszfB192TXO/NI51dyGk18CFv 5pfyYM1Lr5FLoUjjtkZEqx58KYwWt6zMjTydHrlQDefq0i45CBKufODV5eCPmJFy9zcSWzSBo VlnGAUFM2cpr71CWsuYMp9bj/CwZv1bjfE6gJfnNW9HT9SDosRWsDDXEcyQbpcZPp0qS16BuG srMKSB+TnaCc53EvoTn7h7sPrEQR6tgL2z3V10FsgY+oHKxd3kxXneCIaKTEB395mLTI6E4uV W5WbH44uzJqnL34TRUv4AGT/HUTX1z+LOkYV+UX0a8fDLxYskBA9MBaI7II776rAfk1f8v9qZ p7ET/EsBh6Os4PQhFwmX7+UFGxh1rIepgFBnkzlbXk/O8RxVO2a+LpP/bD08RZ5mEoq89NHLo 11aVOC+kul/dibtkrhtdQ2CawWg68hSDf9y4hDiooPlfh0v3Vep7zmRV4xjawaZ/47GEAibSV txzMrWXlV8g/P533JR6xPaL4nnC33vPATBwgNVVyp5ATTj8ihyWrCfrmeGxq/D8hr7LdObLwQ xl8zCBI8rF9rnQX7B5nyS6DfMP/mdjmNmcOsFtv0dmRFX96EPcoNZAMrglaomPAPfpWhvO2AB W9b5OxQ1yVSa+7qtoAmm0oqAI+lb6Adps2XFrJ4Ltk3CP5O+7gPM2NQXggX4qEAQr0XRVJVw X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209242 Archived-At: Dmitry Gutov writes: >>>> However, given that this construct >>>> >>>> (or (file-remote-p FILE 'localname) FILE) >>>> >>>> happens several times in the lisp sources, I wonder whether we shall >>>> give it an own defmacro or defsubst (in master, of course). >>> >>> I have no strong opinion either way, but your commit in master fixing >>> this problem does not have this construct. >> >> Sure. It was a rather general comment, given that we find this construct >> under .../emacs/lisp for at least 11 times, and under .../elpa 4 times. > > I wouldn't mind such a function if we find a good name for it. No > point in making it a macro or a defsubst, I think. `file-localname'? Best regards, Michael.