From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: [PATCH] bind n and p in eww bookmark and histories Date: Wed, 09 Nov 2016 20:11:45 -0500 Message-ID: <87zil816lq.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478740386 18729 195.159.176.226 (10 Nov 2016 01:13:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 10 Nov 2016 01:13:06 +0000 (UTC) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 10 02:13:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4duf-0007fr-JR for ged-emacs-devel@m.gmane.org; Thu, 10 Nov 2016 02:12:21 +0100 Original-Received: from localhost ([::1]:43247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4dui-00084T-A3 for ged-emacs-devel@m.gmane.org; Wed, 09 Nov 2016 20:12:24 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4duB-00084D-Iv for emacs-devel@gnu.org; Wed, 09 Nov 2016 20:11:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4du8-0003I7-F9 for emacs-devel@gnu.org; Wed, 09 Nov 2016 20:11:51 -0500 Original-Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4du8-0003Hs-8t for emacs-devel@gnu.org; Wed, 09 Nov 2016 20:11:48 -0500 Original-Received: by mail-qt0-x243.google.com with SMTP id m48so9644752qta.2 for ; Wed, 09 Nov 2016 17:11:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=CE5rZ0HNm4HQF/+BPY7LeCAfizyyOgIpGVSh3mshkeo=; b=UkNCZKG/OB8cWoYeYfaJ4U4F1CcsnzXUjfQrmL2b5OAsBZ43ZNkp1CnZQyeYCRIHHN W/JnM+C9IS0PhJnt4EXUKSkbMP6lIvKgRPV8QbC4Dj+T/eTLRhtEwrmdOBRqjlTBY9a4 DII0Yh47cXs+8yFv3jLsCfL8+iJ0cjLU20Mx0JyrQaUhqYWxLufZ2gL1CqSvrPHWHDjp E8MKnhX6aGsSjIlJURmaZgOi/QtvIrLvxE6V4h3cXU/U/upo6iThm9uwqAgEFhdilFDE agdwcTXnHoG35xhbjtP6VsknIl7y5cA4uEd6DUpy7s3wrtqK9F9/jN+Nk5ZzsDQPtYTq QEKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=CE5rZ0HNm4HQF/+BPY7LeCAfizyyOgIpGVSh3mshkeo=; b=YQCcEerdaaXLyd5gMxyupwDjYlnmWKWmg+eK4n0ayCj608Ql+JRIeY1OP/Wee+kZXR mgyTnP8Vzeo02OVdsQqTeHOrbew2DBuUOVkJ4dow/vsjvz53b7A5pvmSwMaYPFu0O1Nb 3DfayQq1o2426tr4DauftDFSCaF2351hBbAmUzo9nmHzDB3ct094z7P7/GOHqR0DWvsa dPsDy9K0GAbs7lFvjRoy6zrHVMxZRn9ZqQxrw/OrCIlip3zaE4CtrMRrhBQf5C5Shpi7 DOxTp9GKmXC0zRSuYWKI3P2HbMeCfCkygw/jPIH6F4dmQULxJa2THYG22DI8LayyDWz9 lsRw== X-Gm-Message-State: ABUngveBkH7rH1SEa4z3Ss3kxz0yO3KvuTBCB9TGmJ1nqzf/xrMy7FCOr7gWigChGnS7IaHo X-Received: by 10.237.35.3 with SMTP id h3mr3023289qtc.155.1478740307053; Wed, 09 Nov 2016 17:11:47 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id 124sm1277280qki.14.2016.11.09.17.11.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Nov 2016 17:11:46 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 61A6C60D69; Wed, 9 Nov 2016 20:11:45 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209315 Archived-At: Hi Lars, I'd like to add these bindings. Not sure if there is a plan for n and p to do something else in eww's bookmark or history, judging from the comments nixed below. diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 7672bf0..1732682 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map (define-key map [(control k)] 'eww-bookmark-kill) (define-key map [(control y)] 'eww-bookmark-yank) (define-key map "\r" 'eww-bookmark-browse) + (define-key map "n" 'next-line) + (define-key map "p" 'previous-line) (easy-menu-define nil map "Menu for `eww-bookmark-mode-map'." @@ -1818,8 +1820,8 @@ eww-history-browse (defvar eww-history-mode-map (let ((map (make-sparse-keymap))) (define-key map "\r" 'eww-history-browse) -;; (define-key map "n" 'next-error-no-select) -;; (define-key map "p" 'previous-error-no-select) + (define-key map "n" 'next-line) + (define-key map "p" 'previous-line) (easy-menu-define nil map "Menu for `eww-history-mode-map'."