From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#25360: File mode specification errors during building Date: Fri, 20 Jan 2017 13:43:44 +0000 Message-ID: <87ziilaltb.fsf@russet.org.uk> References: <8760lndxlz.fsf@russet.org.uk> <83bmvfdk2r.fsf@gnu.org> <8737gqsqqr.fsf@russet.org.uk> <83ziiyda4y.fsf@gnu.org> <87inpj1288.fsf@russet.org.uk> <834m13caay.fsf@gnu.org> <87k29ylk8h.fsf@russet.org.uk> <87mvest1vz.fsf@russet.org.uk> <87h94zyj5s.fsf@users.sourceforge.net> <1760ldfurw.fsf@fencepost.gnu.org> <87k29t4a3d.fsf@russet.org.uk> <8737ghxjce.fsf@users.sourceforge.net> <8737gf8h0g.fsf@russet.org.uk> <83k29r6nnw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484922192 18998 195.159.176.226 (20 Jan 2017 14:23:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jan 2017 14:23:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) Cc: 25360@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 20 15:23:03 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUa5a-0003On-6m for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jan 2017 15:22:50 +0100 Original-Received: from localhost ([::1]:55087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUa5f-0004dE-2E for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jan 2017 09:22:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUZU6-0005cl-1O for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 08:44:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUZU2-00054k-Sb for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 08:44:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37918) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cUZU2-00054e-Os for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 08:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cUZU2-0006yN-Gu for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2017 08:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2017 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25360-submit@debbugs.gnu.org id=B25360.148491983426781 (code B ref 25360); Fri, 20 Jan 2017 13:44:02 +0000 Original-Received: (at 25360) by debbugs.gnu.org; 20 Jan 2017 13:43:54 +0000 Original-Received: from localhost ([127.0.0.1]:36117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUZTu-0006xt-AN for submit@debbugs.gnu.org; Fri, 20 Jan 2017 08:43:54 -0500 Original-Received: from mailgw.mycpanelcloud.co.uk ([185.116.214.205]:51043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cUZTs-0006xd-L6 for 25360@debbugs.gnu.org; Fri, 20 Jan 2017 08:43:53 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 8174DC4E72 for <25360@debbugs.gnu.org>; Fri, 20 Jan 2017 13:43:23 +0000 (GMT) X-Virus-Scanned: by SpamTitan at mycpanelcloud.co.uk Original-Received: from mailgw.mycpanelcloud.co.uk (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 8E037C4BA4 for <25360@debbugs.gnu.org>; Fri, 20 Jan 2017 13:43:22 +0000 (GMT) Original-Received: from cloud103.planethippo.com (cloud103.planethippo.com [31.216.48.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTPS id 846C3C4A3C for <25360@debbugs.gnu.org>; Fri, 20 Jan 2017 13:43:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=u8j/4tcuBAFC+1urHCY91N+i1LIKuniEH2ffWxfdwBU=; b=JH/ZcPvRN1yXKyBk+R7I9t9PE poFme3XYQt1Qgn3/gFit9kHU24eq+H31awKEyd/Elr/o7K03VnsTdaVRcUML8YlXT1/WwKuyXXhfK c9o7poecJ6YEec3a5IMTfdWbqec4p9Gq2/18+SCEvX6PSrzsk8A25y6uJlm9cw4amBStbWck0gz5T 7mEfHp3nGtNAdH7w+hsum6mENBsiv1MQke6Mp7phh8KZcFFLwTrkvyMpV4TKnSrVuNZuAe0C4QDnn zuPv7gjZg64S2JdW5Bv8Ob+XxkTp6cZhZMYBrJNdAhmmhY7I/UZkQYo5qr2vMXqU+kxw4knuIkRdL h/0VsYGZQ==; Original-Received: from janus-nat-128-240-225-37.ncl.ac.uk ([128.240.225.37]:34824 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1cUZTl-000KRm-CD; Fri, 20 Jan 2017 13:43:45 +0000 In-Reply-To: (Noam Postavsky's message of "Thu, 19 Jan 2017 12:06:07 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128275 Archived-At: Noam Postavsky writes: > On Thu, Jan 19, 2017 at 11:05 AM, Eli Zaretskii wrote: >>> From: phillip.lord@russet.org.uk (Phillip Lord) >>> Cc: Glenn Morris , 25360@debbugs.gnu.org, Eli Zaretskii >>> Date: Thu, 19 Jan 2017 10:45:51 +0000 >>> >>> > I believe it does respect "coding:" in general (at least it looks like >>> > there are some comments to that effect in Finsert_file_contents), but >>> > indeed it doesn't matter in this case because we're let-binding >>> > `coding-system-for-read' which overrides that. >>> >>> I have checked this now with a full bootstrap and it appears not to >>> work, unfortunately -- the .el files that are generated are broken (this >>> isn't obvious until they fail to byte-compile -- you have let the build >>> complete). >> >> Every file is broken, or just some of them? If the latter, can you >> name some of them, or try to figure out what they have in common? > > The problem is that (with-temp-buffer) changes the current buffer, > which the converter function expected to be set to the output file > (sorry for not checking this properly before). Attached is a > non-broken version of my previous patch. Ah, yes, you are right. Nothing to do with insert-file-contents at all. Entirely obvious in hindsight, but then isn't it always. Phil