From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Colin Baxter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix potentially hanging url-auth tests Date: Sat, 15 Apr 2017 16:36:07 +0100 Message-ID: <87zifhvg2g.fsf@yandex.com> References: <83fuhop8ed.fsf@gnu.org> <1492247564-13556-1-git-send-email-jarno@malmari.fi> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492270586 13912 195.159.176.226 (15 Apr 2017 15:36:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Apr 2017 15:36:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: , emacs-devel@gnu.org To: Jarno Malmari Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 15 17:36:22 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czPkL-0003WB-1q for ged-emacs-devel@m.gmane.org; Sat, 15 Apr 2017 17:36:21 +0200 Original-Received: from localhost ([::1]:57165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czPkQ-0004jP-RD for ged-emacs-devel@m.gmane.org; Sat, 15 Apr 2017 11:36:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czPkI-0004jJ-MW for emacs-devel@gnu.org; Sat, 15 Apr 2017 11:36:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czPkF-0000pd-Ju for emacs-devel@gnu.org; Sat, 15 Apr 2017 11:36:18 -0400 Original-Received: from forward5j.cmail.yandex.net ([5.255.227.23]:51166) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1czPkF-0000oT-5a for emacs-devel@gnu.org; Sat, 15 Apr 2017 11:36:15 -0400 Original-Received: from smtp1o.mail.yandex.net (smtp1o.mail.yandex.net [37.140.190.26]) by forward5j.cmail.yandex.net (Yandex) with ESMTP id 8709220C98; Sat, 15 Apr 2017 18:36:12 +0300 (MSK) Original-Received: from smtp1o.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1o.mail.yandex.net (Yandex) with ESMTP id ED2A013004B8; Sat, 15 Apr 2017 18:36:11 +0300 (MSK) Original-Received: by smtp1o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id pRoCEnR3Dg-aA9eoJYn; Sat, 15 Apr 2017 18:36:10 +0300 (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1492270571; bh=iCU5FZuEOYSf2qtXTuup7lamFJJnVAKjhD/OtgOcBCU=; h=From:To:Cc:Cc:Subject:References:Date:In-Reply-To:Message-ID; b=ueiMCcs5tUO253+RPhfd5RT2YEc48MEl7AFaJp3u81TRa8qQRboeK8g9IfgcKghuP IT5K5m5ZxI8ftxfC+OF9wEncY7h6/0UekGY6yTu3y5kJItTUecj6AgIR3NqslAK5HR bP6t6H1fTdOLySTzDKe0JkPrto9wgNLEA67oNiW4= Authentication-Results: smtp1o.mail.yandex.net; dkim=pass header.i=@yandex.com X-Yandex-Suid-Status: 1 0,1 0 In-Reply-To: <1492247564-13556-1-git-send-email-jarno@malmari.fi> (Jarno Malmari's message of "Sat, 15 Apr 2017 12:12:44 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAAAFz UkdCAK7OHOkAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgAABdwnLpRPAAAAAxQ TFRF8d8Gwx4p07Wi////YneHdQAAAAFiS0dEAxEMTPIAAAAJcEhZcwAACxIAAAsSAdLdfvwAAAFZ SURBVCjPZZLBasJAEIYnEgveVoiheuyhoE+RQh/AihPMnnrohsan8NAHsOAG9CRiSrNP2X8mpj10 TvPxz+7M/rNEiOFmcqU+tnV56POo+gpVdoM7b729wThlxOFZIS4UTKdIzm+Jgpkr3Es+Yi1j9wpI g+Z1vQdU7KzPG0jo6Ji3YQuwRAPPHBDMRUZDz1ag4TzDLKhSsDsauA5aUR4bPQIo9jTlTgls9zTz UC5a9k5zXtvw+QDgKxXSJhlLI4dp8hAoFtiQA3xnsTQqUIYBnswCUOICgCFRDpTKmTgROFPkpWwV gs+XFBVQLiPAEU/onoOrV4ZM3cOLoWTaTy2eFv17HDyFIVZyXpPCLIQrDFHfRPEypyq5QgWYiM+t WA9YcBf5WZbYGZ+XYnxUeoVWt1p52ZDtlj9ueO24Xzc6Hbm9/YNTqNNT/0VSl3y45e/niQzt/iCj f/EDBae52Zd5lNIAAAAldEVYdGRhdGU6Y3JlYXRlADIwMTctMDItMjFUMTU6MjI6MTgrMDA6MDAy vBNIAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDE3LTAyLTIxVDE1OjIyOjE4KzAwOjAwQ+Gr9AAAABF0 RVh0anBlZzpjb2xvcnNwYWNlADIsdVWfAAAAIHRFWHRqcGVnOnNhbXBsaW5nLWZhY3RvcgAxeDEs MXgxLDF4MemV/HAAAAAASUVORK5CYII= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.255.227.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213979 Archived-At: Dear Jarno, On Sat, Apr 15 2017, Jarno Malmari wrote: > * test/lisp/url/url-auth-tests.el (url-auth-test-digest-auth-retrieve-cache): > (url-auth-test-digest-auth, url-auth-test-digest-auth-opaque): > Set auth-sources variable to nil. > --- > test/lisp/url/url-auth-tests.el | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/test/lisp/url/url-auth-tests.el b/test/lisp/url/url-auth-tests.el > index 30636db..47aafab 100644 > --- a/test/lisp/url/url-auth-tests.el > +++ b/test/lisp/url/url-auth-tests.el > @@ -137,7 +137,9 @@ url-auth-test-challenges > "Check how the entry point retrieves cached authentication. > Essential is how realms and paths are matched." > > - (let* ((url-digest-auth-storage > + (let* ((auth-sources nil) ; Don't use any user authinfo files. They > + ; may even hang the test run if encrypted. > + (url-digest-auth-storage > '(("example.org:80" > ("/path/auth1" "auth1user" "key") > ("/path" "pathuser" "key") > @@ -231,7 +233,8 @@ url-auth-test-challenges > cnonce is used for generating them which is not mocked by the > test and cannot be passed by arguments to `url-digest-auth'." > (dolist (challenge url-auth-test-challenges) > - (let* ((attrs (append > + (let* ((auth-sources nil) ; Don't use any user authinfo files. > + (attrs (append > (list (cons "nonce" (plist-get challenge :nonce))) > (if (plist-get challenge :qop) > (list (cons "qop" (plist-get challenge :qop)))))) > @@ -276,7 +279,8 @@ url-auth-test-challenges > (ert-deftest url-auth-test-digest-auth-opaque () > "Check that `opaque' value is added to result when presented by > the server." > - (let* ((url-digest-auth-storage > + (let* ((auth-sources nil) ; Don't use any user authinfo files. > + (url-digest-auth-storage > '(("example.org:80" ("/" "user" "key")))) > (attrs (list (cons "nonce" "anynonce"))) > auth) This patch works for me. Great. Thank you. Best wishes, Colin. -- Colin Baxter m43cap@yandex.com Key fingerprint = 68A8 799C 0230 16E7 BF68 2A27 BBFA 2492 91F5 41C8