From: Colin Baxter <m43cap@yandex.com>
To: Jarno Malmari <jarno@malmari.fi>
Cc: , emacs-devel@gnu.org
Subject: Re: [PATCH] Fix potentially hanging url-auth tests
Date: Sat, 15 Apr 2017 16:36:07 +0100 [thread overview]
Message-ID: <87zifhvg2g.fsf@yandex.com> (raw)
In-Reply-To: <1492247564-13556-1-git-send-email-jarno@malmari.fi> (Jarno Malmari's message of "Sat, 15 Apr 2017 12:12:44 +0300")
Dear Jarno,
On Sat, Apr 15 2017, Jarno Malmari wrote:
> * test/lisp/url/url-auth-tests.el (url-auth-test-digest-auth-retrieve-cache):
> (url-auth-test-digest-auth, url-auth-test-digest-auth-opaque):
> Set auth-sources variable to nil.
> ---
> test/lisp/url/url-auth-tests.el | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/test/lisp/url/url-auth-tests.el b/test/lisp/url/url-auth-tests.el
> index 30636db..47aafab 100644
> --- a/test/lisp/url/url-auth-tests.el
> +++ b/test/lisp/url/url-auth-tests.el
> @@ -137,7 +137,9 @@ url-auth-test-challenges
> "Check how the entry point retrieves cached authentication.
> Essential is how realms and paths are matched."
>
> - (let* ((url-digest-auth-storage
> + (let* ((auth-sources nil) ; Don't use any user authinfo files. They
> + ; may even hang the test run if encrypted.
> + (url-digest-auth-storage
> '(("example.org:80"
> ("/path/auth1" "auth1user" "key")
> ("/path" "pathuser" "key")
> @@ -231,7 +233,8 @@ url-auth-test-challenges
> cnonce is used for generating them which is not mocked by the
> test and cannot be passed by arguments to `url-digest-auth'."
> (dolist (challenge url-auth-test-challenges)
> - (let* ((attrs (append
> + (let* ((auth-sources nil) ; Don't use any user authinfo files.
> + (attrs (append
> (list (cons "nonce" (plist-get challenge :nonce)))
> (if (plist-get challenge :qop)
> (list (cons "qop" (plist-get challenge :qop))))))
> @@ -276,7 +279,8 @@ url-auth-test-challenges
> (ert-deftest url-auth-test-digest-auth-opaque ()
> "Check that `opaque' value is added to result when presented by
> the server."
> - (let* ((url-digest-auth-storage
> + (let* ((auth-sources nil) ; Don't use any user authinfo files.
> + (url-digest-auth-storage
> '(("example.org:80" ("/" "user" "key"))))
> (attrs (list (cons "nonce" "anynonce")))
> auth)
This patch works for me. Great. Thank you.
Best wishes,
Colin.
--
Colin Baxter
m43cap@yandex.com
Key fingerprint = 68A8 799C 0230 16E7 BF68 2A27 BBFA 2492 91F5 41C8
next prev parent reply other threads:[~2017-04-15 15:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 19:20 url-auth-tests hang if authinfo is encrypted Colin Baxter
2017-04-03 19:40 ` Eli Zaretskii
2017-04-04 6:15 ` Colin Baxter
2017-04-04 14:14 ` Eli Zaretskii
2017-04-15 9:12 ` [PATCH] Fix potentially hanging url-auth tests Jarno Malmari
2017-04-15 15:36 ` Colin Baxter [this message]
2017-04-16 11:21 ` Jarno Malmari
2017-04-04 14:53 ` url-auth-tests hang if authinfo is encrypted Ted Zlatanov
2017-04-04 16:04 ` Andreas Schwab
2017-04-04 20:03 ` Colin Baxter
2017-04-05 6:43 ` Colin Baxter
2017-04-05 13:33 ` Ted Zlatanov
2017-04-06 19:29 ` Jarno Malmari
2017-04-07 7:22 ` Colin Baxter
2017-04-07 7:37 ` Eli Zaretskii
2017-04-07 13:34 ` Colin Baxter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zifhvg2g.fsf@yandex.com \
--to=m43cap@yandex.com \
--cc=emacs-devel@gnu.org \
--cc=jarno@malmari.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.