From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: 26650@debbugs.gnu.org, tino.calancha@gmail.com
Subject: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing
Date: Tue, 23 May 2017 20:18:08 -0400 [thread overview]
Message-ID: <87zie35cqn.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83o9vjnpzn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Apr 2017 18:33:00 +0300")
tags 26650 fixed
close 26650 26.1
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> >> >> + (add-hook 'kill-buffer-hook
>> >> >> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t)
>> >> >
>> >> > This will throw to top-level when _any_ buffer is killed, as long as
>> >> > we are in recursive-edit, no?
>> >> No, because `add-hook' is called with non-nil LOCAL arg.
>> >
>> > Right, sorry for not paying attention.
>>
>> Maybe I should have written
>>
>> (add-hook 'kill-buffer-hook (lambda ...) nil 'local)
>>
>> to emphasize this?
>
> It's up to you, but the fact that I didn't see it is not a reason good
> enough to change anything, IMO.
Coming back to this, I found having the "... nil t)" on the same line as
the lambda confusing to read. So I moved them to the next line; I
didn't change the "t" to "local" [1: ef9f5c672a].
[1: ef9f5c672a]: 2017-05-23 20:11:23 -0400
Protect *Backtrace* from being killed (Bug#26650)
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ef9f5c672a8e248dd7bd682101c03feb2e527340
next prev parent reply other threads:[~2017-05-24 0:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 12:02 bug#26650: 26.0.50; Protect *Backtrace* from accidental killing Tino Calancha
2017-04-25 12:13 ` npostavs
2017-04-25 12:18 ` Tino Calancha
2017-04-25 12:50 ` npostavs
2017-04-25 13:02 ` Tino Calancha
2017-04-26 10:07 ` Eli Zaretskii
2017-04-26 10:36 ` Tino Calancha
2017-04-26 11:03 ` Eli Zaretskii
2017-04-26 12:52 ` npostavs
2017-04-26 13:57 ` Tino Calancha
2017-04-26 15:33 ` Eli Zaretskii
2017-05-24 0:18 ` npostavs [this message]
2017-04-26 10:49 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zie35cqn.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=26650@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.