* bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master
@ 2017-06-21 6:04 Alex
2017-06-25 14:13 ` Alan Mackenzie
[not found] ` <20170625141300.GA17130@acm>
0 siblings, 2 replies; 3+ messages in thread
From: Alex @ 2017-06-21 6:04 UTC (permalink / raw)
To: 27436
cc-defs has this condition to check whether or not to include cl-lib:
======================================
(and (fboundp 'mapcan)
(subrp (symbol-function 'mapcan)))
======================================
As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
true.
Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
it can't be used here?
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master
2017-06-21 6:04 bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master Alex
@ 2017-06-25 14:13 ` Alan Mackenzie
[not found] ` <20170625141300.GA17130@acm>
1 sibling, 0 replies; 3+ messages in thread
From: Alan Mackenzie @ 2017-06-25 14:13 UTC (permalink / raw)
To: Alex; +Cc: 27436
Hello, Alex.
On Wed, Jun 21, 2017 at 00:04:12 -0600, Alex wrote:
> cc-defs has this condition to check whether or not to include cl-lib:
> ======================================
> (and (fboundp 'mapcan)
> (subrp (symbol-function 'mapcan)))
> ======================================
> As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
> true.
Yes. Thanks for taking the trouble to report this bug.
I've committed a fix to master. I'd be grateful if you would confirm it
fixes the problem properly, or tell me what's not quite right.
> Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
> it can't be used here?
CC Mode has always favoured testing features rather than version numbers
and the the base (X)Emacs, so that if a tested feature becomes or ceases
to be available, CC Mode should pick that up automatically. That is
illustrated by the current case, just that here the actual test used was
suboptimal. Hopefully it is now OK.
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <20170625141300.GA17130@acm>]
* bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master
[not found] ` <20170625141300.GA17130@acm>
@ 2017-06-25 19:51 ` Alex
0 siblings, 0 replies; 3+ messages in thread
From: Alex @ 2017-06-25 19:51 UTC (permalink / raw)
To: Alan Mackenzie; +Cc: 27436-done
Alan Mackenzie <acm@muc.de> writes:
> Hello, Alex.
>
> On Wed, Jun 21, 2017 at 00:04:12 -0600, Alex wrote:
>> cc-defs has this condition to check whether or not to include cl-lib:
>
>> ======================================
>> (and (fboundp 'mapcan)
>> (subrp (symbol-function 'mapcan)))
>> ======================================
>
>> As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
>> true.
>
> Yes. Thanks for taking the trouble to report this bug.
>
> I've committed a fix to master. I'd be grateful if you would confirm it
> fixes the problem properly, or tell me what's not quite right.
>
>> Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
>> it can't be used here?
>
> CC Mode has always favoured testing features rather than version numbers
> and the the base (X)Emacs, so that if a tested feature becomes or ceases
> to be available, CC Mode should pick that up automatically. That is
> illustrated by the current case, just that here the actual test used was
> suboptimal. Hopefully it is now OK.
Hello, Alan.
Thanks for the explanation and fix; I can confirm that the problem is
fixed in master. I'll close this bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-25 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 6:04 bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master Alex
2017-06-25 14:13 ` Alan Mackenzie
[not found] ` <20170625141300.GA17130@acm>
2017-06-25 19:51 ` Alex
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.