From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27341: updated patch to fix docstring Date: Sun, 02 Jul 2017 14:32:50 -0400 Message-ID: <87zicmk7u5.fsf@users.sourceforge.net> References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499020336 2722 195.159.176.226 (2 Jul 2017 18:32:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Jul 2017 18:32:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27341@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 02 20:32:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjfG-0000GM-Gc for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jul 2017 20:32:10 +0200 Original-Received: from localhost ([::1]:58892 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRjfK-000307-DK for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jul 2017 14:32:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRjfD-0002zq-3Y for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 14:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRjf8-0007Ax-8S for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 14:32:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRjf8-0007Ah-4i for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 14:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRjf7-0001Si-SM for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 14:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14990202825564 (code B ref 27341); Sun, 02 Jul 2017 18:32:01 +0000 Original-Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 18:31:22 +0000 Original-Received: from localhost ([127.0.0.1]:48995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjeT-0001Rg-O9 for submit@debbugs.gnu.org; Sun, 02 Jul 2017 14:31:21 -0400 Original-Received: from mail-io0-f177.google.com ([209.85.223.177]:33359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjeS-0001RR-9N for 27341@debbugs.gnu.org; Sun, 02 Jul 2017 14:31:20 -0400 Original-Received: by mail-io0-f177.google.com with SMTP id h64so45089246iod.0 for <27341@debbugs.gnu.org>; Sun, 02 Jul 2017 11:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sd1mfv0OT9qzynXn743DyvKMDSd6RmG7TOU9cEMU7go=; b=mZx+DnG1tVRmuUtLLk+KNkiqL2dyvOlTOXRU0t9WiC9IuOw7Pp/apMOBsIt+DxQuI4 xADPIr1dwRrv23Yp+dtbzFDItcksrIxOFVyoVsNkOdJOE4WEbpIDA1rY3XoUhMWCCJAs F5qLo7d9mOiyqnTF7ZCKZkr1IaLw+Sew1/U0wNO2qb5qATOfZ7g9YdpYEoR1/k7oBwrr WMtJaRSzvWSffoC4vY7jB0lPa9LbeSwhahphSnI/d5EIzwUNRVebV4e80tAK9R2Hjp7p y+6+R9df9HxZoagqQ1QhLdEzYX/1pDytKsa/i+1jhfW7SUVE+ih8h7UGb0WuKLOzUR5/ q9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=sd1mfv0OT9qzynXn743DyvKMDSd6RmG7TOU9cEMU7go=; b=PphXf4/aG8NUNCPzXB9lzXWcRP5WrTIPAJ28XaPiQxZIczQ9Q+a5GFGRRKRfEzUMzh t7CY7R1hQuXK2T8FChAw4HL8Yqo1Ol6kba9ODlg7qpD6iH5TSYJhmXtOUKyfwEa5/c30 1dWstYt2Xlp5gFak1ygE6ANcYiCEZ7PsKHPtzDLNXGRj7bZLmGUB+KQePtNB+77bfWOk fsXj8FaTIZzyC43uUlikTkmugeSjF0f4WecjjTldLC/Q+s9xf+tpCA2WZHbvNMhA4mkt CbUc9TeODarMuT64nKuHk3Kl3ffpkjUeaVtb2DvemElTod039U+o+sCyg3WJCCSJZh3o 7jRQ== X-Gm-Message-State: AKS2vOw/3jIO43KcdZw/wmuMP6twoLBR5ZlqmXVGjPCf/o8vyN9LC724 VDAtIqUpzKn5gDfx X-Received: by 10.107.22.2 with SMTP id 2mr33895810iow.32.1499020274473; Sun, 02 Jul 2017 11:31:14 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id t5sm1652413ita.22.2017.07.02.11.31.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 11:31:13 -0700 (PDT) In-Reply-To: <878tkdy37e.fsf@utexas.edu> (Alex Branham's message of "Tue, 27 Jun 2017 15:23:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134099 Archived-At: Alex Branham writes: > On Fri 30 Jun 2017 at 00:54, npostavs@users.sourceforge.net wrote: > >> Could you add a ChangeLog entry to the commit message as described in >> CONTRIBUTE, please? > > Yes, I have done so. Let me know if it's not right. Looks good, thanks. >> Doc strings shouldn't be indented like that, and there should be a >> double space between sentences. > > Fixed. You missed the double spacing before the "Else,". > Actually, we need to check (use-region-p) anyway in case the mark > hasn't been activated yet in the buffer: Hmm, I just tried this and it doesn't quite do the job. I believe the problem is that the (interactive "r") form throws an error when the mark hasn't been activated yet. To handle this case correctly you need to replace the "r" with some lisp code that produces the argument list.