From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Package proposal: EBDB Date: Mon, 14 Aug 2017 16:50:22 -0700 Message-ID: <87zib1675t.fsf@ericabrahamsen.net> References: <87efsxspgv.fsf@ericabrahamsen.net> <87mv784f1h.fsf@ericabrahamsen.net> <87shgwgtyp.fsf@ericabrahamsen.net> <87shgux6s1.fsf@ericabrahamsen.net> <87mv722l8s.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502754704 8557 195.159.176.226 (14 Aug 2017 23:51:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Aug 2017 23:51:44 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 15 01:51:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhP8t-0001V4-M1 for ged-emacs-devel@m.gmane.org; Tue, 15 Aug 2017 01:51:31 +0200 Original-Received: from localhost ([::1]:39763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhP90-0002zk-4v for ged-emacs-devel@m.gmane.org; Mon, 14 Aug 2017 19:51:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhP88-0002yN-KT for emacs-devel@gnu.org; Mon, 14 Aug 2017 19:50:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhP85-0001vk-JR for emacs-devel@gnu.org; Mon, 14 Aug 2017 19:50:44 -0400 Original-Received: from [195.159.176.226] (port=57759 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhP85-0001vX-CV for emacs-devel@gnu.org; Mon, 14 Aug 2017 19:50:41 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dhP7s-0006IR-AO for emacs-devel@gnu.org; Tue, 15 Aug 2017 01:50:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 46 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:aHgtcnX6yVgaP3avfQsl4fN69LM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217553 Archived-At: Stefan Monnier writes: >> Aha! Thank you, that's what I was missing. It seems to have worked, I >> guess I'll know for sure when the package gets built. > > I just noticed the following issues: > - You use oset-default on instance fields. This used to work in earlier > EIEIO and still mostly work now thanks to a hack, but it creates > a weird/adhoc semantics in terms of interaction with the :initform, so > I'd like to get rid of this backward compatibility. Huh, interesting. Is that function completely deprecated, or still usable for class-allocated slots? > - ebdb-vm and ebdb-mu4e will break the compilation of the package if the > user doesn't have VM and mu4e installed. > > The appended patch tries to fix those two, but please take a look at it > to make sure it still works correctly (especially the ebdb-vm part is > quick&dirty, leaving a lot of warnings when VM is not installed, some > of them may be real bugs). I thought about extracting those two into separate packages, and probably should have done that. I pulled all the other libraries that depended on non-core packages into their own separate packages, and I don't know why I didn't do that for these two. Actually, I do know: vm and mu4e aren't installable via the package manager. If I make separate packages, and put a package-requires header in them for vm and mu4e, will package.el be satisfied if a user has installed them via other means? Or will it bark? Another option would be a boatload of (autoload 'function "ext:vm") statements. I'll make your other changes, and maybe just pull ebdb-vm and ebdb-mu4e for now, pending further thought. >> Assuming all goes well, can I push this documentation patch to ELPA? > > Yes, please do, thank you, Will do. Thanks, Eric