From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: [ELPA] Package proposal: EBDB
Date: Mon, 14 Aug 2017 16:50:22 -0700 [thread overview]
Message-ID: <87zib1675t.fsf@ericabrahamsen.net> (raw)
In-Reply-To: jwvmv71kayo.fsf-monnier+gmane.emacs.devel@gnu.org
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Aha! Thank you, that's what I was missing. It seems to have worked, I
>> guess I'll know for sure when the package gets built.
>
> I just noticed the following issues:
> - You use oset-default on instance fields. This used to work in earlier
> EIEIO and still mostly work now thanks to a hack, but it creates
> a weird/adhoc semantics in terms of interaction with the :initform, so
> I'd like to get rid of this backward compatibility.
Huh, interesting. Is that function completely deprecated, or still
usable for class-allocated slots?
> - ebdb-vm and ebdb-mu4e will break the compilation of the package if the
> user doesn't have VM and mu4e installed.
>
> The appended patch tries to fix those two, but please take a look at it
> to make sure it still works correctly (especially the ebdb-vm part is
> quick&dirty, leaving a lot of warnings when VM is not installed, some
> of them may be real bugs).
I thought about extracting those two into separate packages, and
probably should have done that. I pulled all the other libraries that
depended on non-core packages into their own separate packages, and I
don't know why I didn't do that for these two.
Actually, I do know: vm and mu4e aren't installable via the package
manager. If I make separate packages, and put a package-requires header
in them for vm and mu4e, will package.el be satisfied if a user has
installed them via other means? Or will it bark?
Another option would be a boatload of (autoload 'function "ext:vm")
statements.
I'll make your other changes, and maybe just pull ebdb-vm and ebdb-mu4e
for now, pending further thought.
>> Assuming all goes well, can I push this documentation patch to ELPA?
>
> Yes, please do, thank you,
Will do.
Thanks,
Eric
next prev parent reply other threads:[~2017-08-14 23:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-30 19:18 [ELPA] Package proposal: EBDB Eric Abrahamsen
2017-07-31 0:49 ` Richard Stallman
2017-07-31 3:10 ` Eli Zaretskii
2017-07-31 3:12 ` Eric Abrahamsen
2017-07-31 3:28 ` Eli Zaretskii
2017-07-31 3:30 ` Eric Abrahamsen
2017-08-09 21:17 ` Eric Abrahamsen
2017-08-13 1:03 ` Eric Abrahamsen
2017-08-13 21:47 ` Stefan Monnier
2017-08-14 1:44 ` Eric Abrahamsen
2017-08-14 9:45 ` Stefan Monnier
2017-08-14 15:59 ` Eric Abrahamsen
2017-08-14 23:15 ` Stefan Monnier
2017-08-14 23:50 ` Eric Abrahamsen [this message]
2017-08-15 7:49 ` Stefan Monnier
2017-08-15 15:30 ` Eric Abrahamsen
2017-08-17 16:57 ` Eric Abrahamsen
2017-08-17 22:21 ` Stefan Monnier
2017-08-17 22:52 ` Eric Abrahamsen
2017-08-17 23:27 ` Stefan Monnier
2017-08-17 23:31 ` Eric Abrahamsen
2017-08-01 5:33 ` John Wiegley
2017-08-01 16:04 ` Eric Abrahamsen
2017-08-01 22:25 ` John Wiegley
2017-08-01 23:52 ` Eric Abrahamsen
2017-08-02 1:28 ` John Wiegley
2017-08-02 3:08 ` Eric Abrahamsen
2017-08-01 5:58 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2017-08-06 22:12 Roland Winkler
2017-08-07 0:44 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zib1675t.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.