From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Tue, 15 Aug 2017 12:58:27 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87zib0lqdo.fsf@lifelogs.com> References: <83bmo00yw7.fsf@gnu.org> <6d947774-836a-7286-4214-ddc5f516577f@cs.ucla.edu> <87bmngnccv.fsf@lifelogs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502816342 9694 195.159.176.226 (15 Aug 2017 16:59:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 15 Aug 2017 16:59:02 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 15 18:58:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhfB9-00024E-1x for ged-emacs-devel@m.gmane.org; Tue, 15 Aug 2017 18:58:55 +0200 Original-Received: from localhost ([::1]:48170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhfBF-0000kZ-J1 for ged-emacs-devel@m.gmane.org; Tue, 15 Aug 2017 12:59:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhfB2-0000i8-RA for emacs-devel@gnu.org; Tue, 15 Aug 2017 12:58:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhfAz-0005wY-Pd for emacs-devel@gnu.org; Tue, 15 Aug 2017 12:58:48 -0400 Original-Received: from [195.159.176.226] (port=58642 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhfAz-0005w3-Jd for emacs-devel@gnu.org; Tue, 15 Aug 2017 12:58:45 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dhfAn-0000zh-Pl for emacs-devel@gnu.org; Tue, 15 Aug 2017 18:58:33 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 62 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:c3uY7IKHdP86YOMLoOLZN60xLyI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217572 Archived-At: On Tue, 15 Aug 2017 08:52:30 -0700 Paul Eggert wrote: PE> Ted Zlatanov wrote: >> perhaps CONTRIBUTE >> and INSTALL should mention how to compile and run Emacs without running >> Git or expecting a .git/hooks directory? PE> Those files already attempt to do that. In what sense do they fall short? What PE> wording needs to be changed? I guess INSTALL doesn't deal with autogen.sh so it doesn't need changes. I think CONTRIBUTE should mention, right after saying to run autogen.sh, that the above requires Git to be installed. PE> Or perhaps a better way to put it: what went wrong with your build, exactly? Is PE> it something that autogen.sh can detect and work around automatically? It'd be PE> better to automate away any problems than to complicate CONTRIBUTE and INSTALL PE> to work around them. Agreed :) Hence my next paragraph. What went wrong? https://gitlab.com/emacs-ci/emacs/-/jobs/29326689 says #+begin_src text $ ./autogen.sh Checking whether you have the necessary tools... (Read INSTALL.REPO for more details on building Emacs) Checking for autoconf (need at least version 2.65) ... ok Your system has the required tools. Building aclocal.m4 ... Running 'autoreconf -fi -I m4' ... Configuring local git repository... '.git/config' -> '.git/config.~1~' git config transfer.fsckObjects 'true' git config diff.elisp.xfuncname '^\(def[^[:space:]]+[[:space:]]+([^()[:space:]]+)' git config diff.m4.xfuncname '^((m4_)?define|A._DEFUN(_ONCE)?)\([^),]*' git config diff.make.xfuncname '^([$.[:alnum:]_].*:|[[:alnum:]_]+[[:space:]]*([*:+]?[:?]?|!?)=|define .*)' git config diff.shell.xfuncname '^([[:space:]]*[[:alpha:]_][[:alnum:]_]*[[:space:]]*\(\)|[[:alpha:]_][[:alnum:]_]*=)' git config diff.texinfo.xfuncname '^@node[[:space:]]+([^,[:space:]][^,]+)' Installing git hooks... 'build-aux/git-hooks/commit-msg' -> '.git/hooks/commit-msg' cp: cannot create regular file '.git/hooks/commit-msg': No such file or directory ERROR: Job failed: exit code 1 #+end_src So it looks like it assumes that `.git/hooks' exists. I don't know why that's not true in the GitLab checkout. Maybe "Configuring local git repository" could be changed to "Configuring local git repository (run 'autogen.sh autoconf' to skip this step)"? That would probably be the most direct way to help users who don't read the docs :) >> Maybe there could even be a more automatic way to avoid running the Git >> commands inside an automated build, where there's no chance they will be >> needed? PE> That's easy, just run "rm -r .git". I don't think this is a good idea, though. Yes, it's a radical surgery. I think the text change suggested above is a gentler way. Ted