Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn

Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn

[Stefan Monnier]

>     Fix up headers for ebdb-i18n-chn
    
>     * packages/ebdb-i18n-chn/ebdb-i18n-chn.el: There was no Maintainer
>       header -- was that why it didn't deploy?

No: "Author" is used when there's no "maintainer" (actually: "was
used", since currently that part of the infrastructure is not working).

The problem was in the "Package-Requires" line.  I just fixed it.


        Stefan

Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn

[Eric Abrahamsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>     Fix up headers for ebdb-i18n-chn
>     
>>     * packages/ebdb-i18n-chn/ebdb-i18n-chn.el: There was no Maintainer
>>       header -- was that why it didn't deploy?
>
> No: "Author" is used when there's no "maintainer" (actually: "was
> used", since currently that part of the infrastructure is not working).
>
> The problem was in the "Package-Requires" line.  I just fixed it.

Man, you don't realize how much you depend on paredit until you're in a
comment section.

Thanks, as always,
Eric

Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn

[João Távora]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Man, you don't realize how much you depend on paredit until you're in a
> comment section.

Use `M-x electic-pair-mode` instead, works fine in comments :-)

João

Re: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn

[Eric Abrahamsen]

joaotavora@gmail.com (João Távora) writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Man, you don't realize how much you depend on paredit until you're in a
>> comment section.
>
> Use `M-x electic-pair-mode` instead, works fine in comments :-)

Maybe I'll try retraining my fingers :)

Gnu Elpa broken (was: [elpa] master 31e41ab: Fix up headers for ebdb-i18n-chn)

[Michael Heerdegen]

Hi,

seems Gnu Elpa is broken since some days due to ebdb for me: "make"
fails in a fresh checkout of the repository.

Here is what I get:

| elpa> make
| Byte compiling packages/ebdb-i18n-chn/ebdb-i18n-chn.el
| Unable to activate package ‘helm-ebdb’.
| Required package ‘helm-1.0’ is unavailable
| Unable to activate package ‘ebdb-i18n-chn’.
| Required package ‘pyim-1.6.0’ is unavailable
| 
| In toplevel form:
| packages/ebdb-i18n-chn/ebdb-i18n-chn.el:36:1:Error: Cannot open load file: No such file or directory, pyim
| GNUmakefile:178: recipe for target 'packages/ebdb-i18n-chn/ebdb-i18n-chn.elc' failed
| make: *** [packages/ebdb-i18n-chn/ebdb-i18n-chn.elc] Error 1


TIA,

Michael.

Re: Gnu Elpa broken

[Stefan Monnier]

> seems GNU ELPA is broken since some days due to ebdb for me: "make"

GNU ELPA (i.e. the archive distribution) is OK, but indeed the elpa.git
checkout can't be directly built without error unless you have helm and
pyim installed.

I use the patch below locally for now.
Haven't yet tried to push this to Eric.


        Stefan


--- a/packages/ebdb-i18n-chn/ebdb-i18n-chn.el
+++ b/packages/ebdb-i18n-chn/ebdb-i18n-chn.el
@@ -1,4 +1,4 @@
-;;; ebdb-chn.el --- China-specific internationalization support for EBDB  -*- lexical-binding: t; -*-
+;;; ebdb-i18n-chn.el --- China-specific internationalization support for EBDB  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2016-2017  Free Software Foundation, Inc.
 
@@ -33,7 +33,7 @@
 
 ;;; Code:
 
-(require 'pyim)
+(when t (require 'pyim))                ;Don't require during compile-time.
 (require 'ebdb-i18n)
 
 (cl-defmethod ebdb-string-i18n ((phone ebdb-field-phone)
diff --git a/packages/helm-ebdb/helm-ebdb.el b/packages/helm-ebdb/helm-ebdb.el
index 63fda85f9..b160ca9e8 100644
--- a/packages/helm-ebdb/helm-ebdb.el
+++ b/packages/helm-ebdb/helm-ebdb.el
@@ -27,8 +27,8 @@
 
 ;;; Code:
 
-(require 'ebdb)
-(require 'helm)
+(require 'ebdb-com)
+(when t (require 'helm))                ;Don't require during compile-time.
 
 (declare-function ebdb-display-records "ext:ebdb-com"
                  (records &optional fmt append select pop buf))

Re: Gnu Elpa broken

[John Wiegley]

>>>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

SM> I use the patch below locally for now. Haven't yet tried to push this to
SM> Eric.

Thanks for acting on this quickly, Stefan.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Gnu Elpa broken

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I use the patch below locally for now.

FWIW that still gives me

| In toplevel form:
| packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: No such file or directory, ebdb
| GNUmakefile:178: recipe for target 'packages/counsel-ebdb/counsel-ebdb.elc' failed
| make: *** [packages/counsel-ebdb/counsel-ebdb.elc] Error 1

BTW, does "use [...] locally" mean the server still successfully builds
all packages?

Anyway, thanks for caring.


Michael.

Re: Gnu Elpa broken

[Eric Abrahamsen]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> I use the patch below locally for now.
>
> FWIW that still gives me
>
> | In toplevel form:
> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: No such file or directory, ebdb
> | GNUmakefile:178: recipe for target 'packages/counsel-ebdb/counsel-ebdb.elc' failed
> | make: *** [packages/counsel-ebdb/counsel-ebdb.elc] Error 1

There are three ebdb-* packages in elpa that depend on external packages
that are only found in melpa. I didn't realize that elpa packages
couldn't require melpa packages, though I suppose that makes sense.

I can push patches to all three packages using Stefan's (when t ...)
trick right now.

> BTW, does "use [...] locally" mean the server still successfully builds
> all packages?

I'm also curious why this didn't break right away.

Sorry for making a mess.

Eric

Re: Gnu Elpa broken

[Eric Abrahamsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>
>>> I use the patch below locally for now.
>>
>> FWIW that still gives me
>>
>> | In toplevel form:
>> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file: No such file or directory, ebdb
>> | GNUmakefile:178: recipe for target 'packages/counsel-ebdb/counsel-ebdb.elc' failed
>> | make: *** [packages/counsel-ebdb/counsel-ebdb.elc] Error 1
>
> There are three ebdb-* packages in elpa that depend on external packages
> that are only found in melpa. I didn't realize that elpa packages
> couldn't require melpa packages, though I suppose that makes sense.
>
> I can push patches to all three packages using Stefan's (when t ...)
> trick right now.

Done. Still produces a lot of warnings during the make process, though.

Re: Gnu Elpa broken

[Stefan Monnier]

>> I use the patch below locally for now.
> FWIW that still gives me
> | In toplevel form:
> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file:
> | No such file or directory, ebdb

That's odd: ebdb *is* in elpa.git, so your Emacs should be able to find
it (assuming you configured package.el to look for packages there, of
course).

> BTW, does "use [...] locally" mean the server still successfully builds
> all packages?

ELPA packages are distributed in source form and compiled on the
end-user's system, where package.el's dependency management should
ensure that pyim and helm are installed before he can install
ebdb-i18n-chn and helm-ebdb.

So, those compilation failures don't affect GNU ELPA.


        Stefan

Re: Gnu Elpa broken

[Eric Abrahamsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>> I use the patch below locally for now.
>> FWIW that still gives me
>> | In toplevel form:
>> | packages/counsel-ebdb/counsel-ebdb.el:29:1:Error: Cannot open load file:
>> | No such file or directory, ebdb
>
> That's odd: ebdb *is* in elpa.git, so your Emacs should be able to find
> it (assuming you configured package.el to look for packages there, of
> course).

Would he have to run "make externals" before that works?

Shooting in the dark... Anyway let me know if there's something more I
need to do...

Re: Gnu Elpa broken

[Stefan Monnier]

>> That's odd: ebdb *is* in elpa.git, so your Emacs should be able to find
>> it (assuming you configured package.el to look for packages there, of
>> course).
> Would he have to run "make externals" before that works?

Yes, of course (I just checked: it's mentioned in the README).
But indeed, maybe he just forgot to do that.


        Stefan

Re: Gnu Elpa broken

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > Would he have to run "make externals" before that works?
>
> Yes, of course (I just checked: it's mentioned in the README).
> But indeed, maybe he just forgot to do that.

Yes, he did (more exactly, I had read the README, but somehow didn't
expect that these steps depend on each other).


Thanks,

Michael.