From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28831: 27.0.50; debbugs: funny address in To field Date: Fri, 20 Oct 2017 08:55:52 -0400 Message-ID: <87zi8mdllz.fsf@users.sourceforge.net> References: <877evy3vw4.fsf@gmail.com> <87376efypo.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1508504248 8335 195.159.176.226 (20 Oct 2017 12:57:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Oct 2017 12:57:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28831@debbugs.gnu.org, Tino Calancha To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 20 14:57:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5WrL-00087R-GT for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Oct 2017 14:57:07 +0200 Original-Received: from localhost ([::1]:53942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5WrS-0006ff-Qn for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Oct 2017 08:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5WrK-0006fC-5e for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 08:57:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5WrG-0004zs-AO for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 08:57:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5WrG-0004zm-5v for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 08:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e5WrF-0002yv-Pm for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2017 08:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Oct 2017 12:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28831 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28831-submit@debbugs.gnu.org id=B28831.150850417011393 (code B ref 28831); Fri, 20 Oct 2017 12:57:01 +0000 Original-Received: (at 28831) by debbugs.gnu.org; 20 Oct 2017 12:56:10 +0000 Original-Received: from localhost ([127.0.0.1]:51260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5WqM-0002xd-Vv for submit@debbugs.gnu.org; Fri, 20 Oct 2017 08:56:10 -0400 Original-Received: from mail-io0-f182.google.com ([209.85.223.182]:46157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5WqH-0002ww-DR for 28831@debbugs.gnu.org; Fri, 20 Oct 2017 08:56:05 -0400 Original-Received: by mail-io0-f182.google.com with SMTP id 101so13119074ioj.3 for <28831@debbugs.gnu.org>; Fri, 20 Oct 2017 05:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gaC7hYcKVSqeFHEi4xY/ylIllJF06/vzGp+eblmzknk=; b=Lh8tYWV+mttegYsxqgq7rQE0aoMXB+dSxKD0aQ+N+O1/weg2oq5U+9nW0ybkamHzKp xf6BCi0HWJHL8ICcJmgE8rzb8xDu0S5/sK5ox1J1x78O40iQ6ByXloFJDhpKmiz/KBej oPaGvshF7Dgr9IxPjHMkWuIe7xIgbJp6U7uoQyXN+UhhzTfvW814vutZV4bzuJoqofT3 Ce8hICQMlJPmhJhfuQeRgRyccFSkrBGljIHDc0e5RNv2ZKGI6W5g9rtADTRhH1pZ91lz k+wSKxZ8gEx0toqcT8GKzWICo4Ln4WWmyljU8Tn10AaljQQ6C/pP6/SgAcV5bqxhBt/H wUwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=gaC7hYcKVSqeFHEi4xY/ylIllJF06/vzGp+eblmzknk=; b=rKoVdBrP1lQV2AVAkrDtZuHRWSQNBffkLlnEFv74BHwmko8kzJb9PgXMw1bSIzWqRr cQjeBV2c+8T1vSbDzvDjkXjn/NdirtA648V5342ZLDh6Y+IxBksUQWp4aKC1ClTicqah rCiZTVxbZ3FBTUXKbu0QlK3tyYfpc14TZNdBjAAfbQG8gOyiXCQJCbB9ykLb5UvNCEqB X9MTeqJQ80uJDLCHiL9wd/H50gaoL5rZFwkc8w+AXbOB272lpZ+KTEFNEsTwFg7vhu0L hBbgZwg3G8Mgbmkh48UiiIK7IOmvnafu5xPAKyjVYW+jng0MzKdqKW622N2KFnRGWmlz 2PIg== X-Gm-Message-State: AMCzsaV4jhk+nslyD4d77t94qauG7a1X92DB+QRdo77LKCTsr+oeeUMk pHieUnFUXkfWv0XE0+99FM8= X-Google-Smtp-Source: ABhQp+SivFfOZqNGD3r2PWIb3+k9ikjwJ4wwcaK0D149Ybpa8+NMQKlXOXUfmQAMT3rjlTSFeIDPzg== X-Received: by 10.107.70.24 with SMTP id t24mr6446125ioa.14.1508504155608; Fri, 20 Oct 2017 05:55:55 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v4sm318798iod.17.2017.10.20.05.55.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Oct 2017 05:55:53 -0700 (PDT) In-Reply-To: (Lars Ingebrigtsen's message of "Fri, 20 Oct 2017 11:35:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138764 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Noam Postavsky writes: > >> - (replace-regexp-in-string "^http://" "" mbox-url))))) >> + (replace-regexp-in-string "^https://" "" mbox-url))))) > > Perhaps that should be > >> + (replace-regexp-in-string "^https?://" "" mbox-url))))) Or maybe we could use url-parse? Seems a bit neater. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Handle-https-url-for-debbugs-mbox-Bug-28831.patch Content-Description: patch >From 992b5b8a33eab5ea0afa020030408f76dcfd4330 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 19 Oct 2017 20:07:05 -0400 Subject: [PATCH v2] Handle https url for debbugs mbox (Bug#28831) In 2017-09-13 "Prefer HTTPS to FTP and HTTP in documentation", gnus-bug-group-download-format-alist was updated to use https for the debbugs.gnu.org mbox links, but gnus-read-ephemeral-bug-group assumed http links. * lisp/gnus/gnus-group.el (gnus-read-ephemeral-bug-group): Use url-parse functions to get the host name, instead of ad-hoc regexps. --- lisp/gnus/gnus-group.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 985efe6272..4a41c49590 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -2467,9 +2467,7 @@ gnus-read-ephemeral-bug-group ;; Add the debbugs address so that we can respond to reports easily. (let ((address (format "%s@%s" (car ids) - (replace-regexp-in-string - "/.*$" "" - (replace-regexp-in-string "^http://" "" mbox-url))))) + (url-host (url-generic-parse-url mbox-url))))) (goto-char (point-min)) (while (re-search-forward (concat "^" message-unix-mail-delimiter) nil t) -- 2.11.0 --=-=-=--