From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Date: Sat, 21 Oct 2017 19:33:23 -0400 Message-ID: <87zi8kcbzw.fsf@users.sourceforge.net> References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508628865 17438 195.159.176.226 (21 Oct 2017 23:34:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Oct 2017 23:34:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28803@debbugs.gnu.org To: John Williams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 22 01:34:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63HI-00028S-8k for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Oct 2017 01:34:04 +0200 Original-Received: from localhost ([::1]:59501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e63HP-0003A1-PC for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Oct 2017 19:34:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e63HJ-00039L-So for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 19:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e63HG-0003Kd-Nk for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 19:34:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46069) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e63HG-0003Iw-Jo for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 19:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e63HG-00049a-9E for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 19:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 23:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150862881415929 (code B ref 28803); Sat, 21 Oct 2017 23:34:02 +0000 Original-Received: (at 28803) by debbugs.gnu.org; 21 Oct 2017 23:33:34 +0000 Original-Received: from localhost ([127.0.0.1]:54750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Go-00048m-EV for submit@debbugs.gnu.org; Sat, 21 Oct 2017 19:33:34 -0400 Original-Received: from mail-it0-f43.google.com ([209.85.214.43]:51373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Gm-00048R-6x; Sat, 21 Oct 2017 19:33:32 -0400 Original-Received: by mail-it0-f43.google.com with SMTP id o135so2314348itb.0; Sat, 21 Oct 2017 16:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=eiEVajC15xE0qEzs5jU1bxznQEaR3R4Pu7WbhlX5x66PTkmy1LdEZZp3wRXMI77XoU uz6ww7LZLJreQKE8XzS4vJ6u1RceUZKx0RdUJbtdT7H7EEfginO2L+VUsxx362xwPULp plY36O5FnpwE/SB4wGmC9IlNruMNmifS+DrcC8hRJOQUYMfUQVtzOH1Z7RRCZRCWLNgq d7OKOHcbSGFKV8hLbdTf+5lAW9HrrZTpLDd4kW27mV4CkyxhR28sr0AEq0xZeVPtKb+B 7rx1EvnvIkDrmj59FarRaaLLpV/yfoKW/A3XGXqorhTg4FqD4X2vUKu2kzmSVVzenlj8 mQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=HCryJwJUl7Hlq3fuvkbp5PYwOPTUc0t95t3lerjdPBuFXXQFXs8a8/mOITYmcmrfdS MDOMzsXthBUiH/kmlNTmLYIiK4MyFy02Dwf4ykl8EsJBOyFRIUPKkF+9gbsivrRq2W7L wsUO3WqXTxWJWEf/sSt2ugrkqFYnLRCrXJi7YJyhjtxwzbWfujnHXuh7ObXxqSb52NV9 a6hNnbg8M+WgGvJwBp/qpk0AnasJTO2cmOWy86DJlt3PEm56u0f5uYeVJ/I9KJakqpHb 9jCeT3oN7/IdXAaTcXXgcYvoYsu4U6smGaI2D16o50pLMagSwy6o8Uq9gDxZto068L9o cHnA== X-Gm-Message-State: AMCzsaVcOe/xL0XlfNYsvEjnL/mDk0iPCqc87NDrtV8pLaoghGcG1SNF lX1SFwoWnPzJYZBQ/XXvkxMuNw== X-Google-Smtp-Source: ABhQp+QINMEhCpDuMyXNJcHA063fGxGA+DN4ZJXp2iqyIO2+aFRD/r91xTsX/rxzAr43Dr4ZYKWucQ== X-Received: by 10.36.164.75 with SMTP id v11mr4211998iti.33.1508628806353; Sat, 21 Oct 2017 16:33:26 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m12sm903590ita.17.2017.10.21.16.33.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 16:33:25 -0700 (PDT) In-Reply-To: <874lr19trw.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 14 Oct 2017 19:47:15 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138830 Archived-At: tags 28803 fixed close 28803 26.1 unarchive 14860 merge 28803 14860 quit Noam Postavsky writes: > John Williams writes: > >> Oops. Is there anything that can be salvaged from my patch? Aside >> from fixing the bug, it also adds a unit test and refactors the logic >> for finding a function's argument list into a separate function >> that's not part of the help system. > > We could add the test, it seems to be passing in emacs-26. I've pushed the test. [1: 237e96bc52]: 2017-10-21 19:20:46 -0400 Test that advice doesn't trigger bytecomp warnings (Bug#28803) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=237e96bc5259e59ac5623a93a47f64abffab4e0b