From: Michael Heerdegen <michael_heerdegen@web.de>
To: Allen Li <vianchielfaura@gmail.com>
Cc: 29465@debbugs.gnu.org
Subject: bug#29465: 25.3; Confusing message for dired-do-shell-command substitution
Date: Mon, 27 Nov 2017 10:07:20 +0100 [thread overview]
Message-ID: <87zi78jdiv.fsf@web.de> (raw)
In-Reply-To: <CAJr1M6ffc=S-LVnoh-+ZQQjMxhX6EgWksO4DDi6j8KdbyxkXwg@mail.gmail.com> (Allen Li's message of "Sun, 26 Nov 2017 23:34:33 -0800")
Allen Li <vianchielfaura@gmail.com> writes:
> I have included two patches. The first is to fix the documentation
> string which I encountered while reading the code, the second is for
> my proposed solution of removing the confirmation message.
I think this would also solve Bug#28969 that I had reported some time
ago. I wanted to try your patch but...
> diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
> index 57eb216231..15bb3173b7 100644
> --- a/lisp/dired-aux.el
> +++ b/lisp/dired-aux.el
> @@ -744,20 +744,10 @@ dired-do-shell-command
> (dired--star-or-qmark-p res str))
> (setq res (replace-match "" t t res 2)))
> (string-match regexp res))))
> - (let* ((on-each (not (dired--star-or-qmark-p command "*" 'keep)))
> - (no-subst (not (dired--star-or-qmark-p command "?" 'keep)))
Here seems to be a problem with leading whitespace in the first line -
applying this patch fails for me.
Michael.
next prev parent reply other threads:[~2017-11-27 9:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 7:16 bug#29465: 25.3; Confusing message for dired-do-shell-command substitution Allen Li
2017-11-27 7:34 ` Allen Li
2017-11-27 9:07 ` Michael Heerdegen [this message]
2017-11-27 15:58 ` Eli Zaretskii
2017-11-28 3:50 ` Tino Calancha
2017-11-28 8:25 ` Allen Li
2017-11-28 16:26 ` Eli Zaretskii
2017-11-28 20:13 ` Allen Li
2017-11-29 4:20 ` Drew Adams
2017-12-01 8:36 ` Eli Zaretskii
2017-12-02 6:31 ` Allen Li
2017-12-02 7:32 ` Tino Calancha
2017-12-02 8:22 ` Allen Li
2022-03-22 16:48 ` Lars Ingebrigtsen
2017-11-28 16:15 ` Eli Zaretskii
[not found] <<CAJr1M6f71vv2W090wPw8q_10wK=OwfgvMfM7DMiPn9G8oyY8AA@mail.gmail.com>
[not found] ` <<83vahv67eb.fsf@gnu.org>
[not found] ` <<87fu8zukmb.fsf@gmail.com>
[not found] ` <<CAJr1M6cuB0RPcUfzsGHCGt+8m6-KH58FX4NoD==APb7dksrs2g@mail.gmail.com>
[not found] ` <<83609u5pyr.fsf@gnu.org>
[not found] ` <<CAJr1M6cT578dcFT4Uvg29===-q=7omx5DG+JSTuqczjO3paGgg@mail.gmail.com>
[not found] ` <<29b407d1-e1f6-4676-a686-ccdf19af8bb4@default>
[not found] ` <<83mv323kvx.fsf@gnu.org>
2017-12-01 15:42 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi78jdiv.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=29465@debbugs.gnu.org \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.